disk/api.py: resize2fs needs tests + better log

Bug #1270088 reported by Sahid Orentino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Sahid Orentino

Bug Description

In disk/api.py the method resize2fs does not have a test.

Also, the method firstly use e2fsck to check if the filesystem is correct. if the program failed no information was logged and the actual algorithm try to do the resize anyway. Same with e2fsck, if resize2fs failed not information are logged.

We need to add tests for this function and log every error returned.

Changed in nova:
assignee: nobody → sahid (sahid-ferdjaoui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/67412

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/67412
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=da84cb078e9820c7c9d64bdccd904e1b257ab96e
Submitter: Jenkins
Branch: master

commit da84cb078e9820c7c9d64bdccd904e1b257ab96e
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Fri Jan 17 11:09:34 2014 +0100

    disk/api.py: resize2fs fails silently + adds tests

    + The method disk.api.resize2fs fails silently and should
      writes some information in the log.
    + Adds missing tests to disk.api.resize2fs

    Change-Id: I4edd88fb85a73c75628958e3f2ea668c0d3cad89
    Closes-Bug: #1270088

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.