not validate maxsize minsize when create "AWS::AutoScaling::AutoScalingGroup"

Bug #1270070 reported by Zhang Yang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Zhang Yang

Bug Description

"AWS::AutoScaling::AutoScalingGroup" can be created successfully even the template is wrong,such as:

 MinSize > MaxSize :

  WebServerGroup:
    Properties:
      AvailabilityZones: {'Fn::GetAZs': ''}
      LaunchConfigurationName: {Ref: LaunchConfig}
      MaxSize: '1'
      MinSize: '3'
    Type: AWS::AutoScaling::AutoScalingGroup

size < 0:

  WebServerGroup:
    Properties:
      AvailabilityZones: {'Fn::GetAZs': ''}
      LaunchConfigurationName: {Ref: LaunchConfig}
      MaxSize: '-1'
      MinSize: '-3'
    Type: AWS::AutoScaling::AutoScalingGroup

Changed in heat:
assignee: nobody → Zhang Yang (neil-zhangyang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/67618

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/67618
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e1d75b4a7ca88e7b92592db9864e6720ac649452
Submitter: Jenkins
Branch: master

commit e1d75b4a7ca88e7b92592db9864e6720ac649452
Author: Zhang Yang <email address hidden>
Date: Fri Jan 17 19:07:18 2014 -0800

    add the validation of MaxSize ,MinSize and DesiredCapacity

    * check whether MinSize is less than MaxSize
    * check whether MinSize and MaxSize is not less than 0
    * if DesiredCapacity is offered,check whether it is between
      MinSize and MaxSize

    Change-Id: I79a7b6c0e61f109ac7e71d3fd48d93fb741bbc64
    Closes-Bug: #1270070

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.