Ubuntu
smokeping package

/etc/init.d/smokeping status does not find running process

Bug #1269979 reported by Craig Miskell
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
smokeping (Debian)
Fix Released
Unknown
smokeping (Ubuntu)
Triaged
High
Unassigned

Bug Description

pidofproc assumes either a PID file in /var/run/smokeping.pid, or failing that uses pidof to find the PID.

A running smokeping looks like this:
root@myhost:~# ps uawx|grep smokeping
109 26838 0.0 0.5 141824 22296 ? Ss 11:41 0:00 /usr/sbin/smokeping [FPing]

And 'pidof smokeping' doesn't find it (presumably due to the [FPing]).

Can be fixed in the init script with the -p option to pidofproc:
pidofproc -p $PIDFILE "$DAEMON" > /dev/null

Patch attached.

Revision history for this message
Craig Miskell (3-crjig-7) wrote :
Andreas Moog (ampelbein)
Changed in smokeping (Ubuntu):
importance: Undecided → High
status: New → Triaged
Bug Watch Updater (bug-watch-updater)
Changed in smokeping (Debian):
status: Unknown → New
Revision history for this message
Chris Malton (chrism-u) wrote :

Craig's patch in #1 looks good - applies cleanly on my test install.

Bug Watch Updater (bug-watch-updater)
Changed in smokeping (Debian):
status: New → Fix Released
Revision history for this message
Luca Lesinigo (luca404) wrote :

We are using Craig's patch too, on trusty, and works good.
It's really simple and as far as I can tell there's no risk of breaking anything else.
Xenial already has it.

Could this be merged in Trusty's package?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.