ACQ user request can result in double (or quadruple) holds placement
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Confirmed
|
Medium
|
Jason Etheridge |
Bug Description
Evergreen 2.4+
1. Acquisitions user requests can be used to generate hold requests. Hold generation occurs when asset (bibs, volumes, copies) creation for a lineitem occurs. However, asset creation for lineitems can happen multiple times, since we always ensure assets are generated during activation, even if they were generated earlier in the process. In these cases, the assets themselves are not duplicated, since we check each copy to verify it needs importing. We are not, however, doing the same thing for hold requests generated from user requests. We need a way to indicate that a user request has already produced a hold. Or, alternatively, skip hold placement when a matching hold for the user already exists.
2. A secondary thinko bug further complicates this problem. In lineitem list asset creation, in some circumstances, we process each lineitem twice. I have a patch for this and will post it shortly.
So, when both issues occur, we can get up to 4 hold requests per user request.
no longer affects: | evergreen/2.7 |
no longer affects: | evergreen/2.6 |
Changed in evergreen: | |
assignee: | nobody → Jason Etheridge (phasefx) |
Fix for issue #2 pushed.
https:/ /bugs.launchpad .net/evergreen/ +bug/1269865