Create action button does not display the "+" icon

Bug #1269653 reported by Lin Hua Cheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Lin Hua Cheng

Bug Description

If the Create table actions is created using tables.Action like:

class CreateEndpoint(tables.Action):
    name = "create_endpoint"
    verbose_name = _("Create Endpoint")
    requires_input = False
    classes = ("show-spinner", "btn-create", )

The "+" icon does not show up.

If the class tables.LinkAction is used, it works fine.

The problem is in the horizon.less:

 a.btn-create, a.btn-launch {
      .btn-icon(-403px, -92px);
    }

It only works <a>, but not <button> which is rendered when tables.Action is used.

Changed in horizon:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/68028

Changed in horizon:
assignee: nobody → Lin Hua Cheng (lin-hua-cheng)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/68028
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6250825b6ad897d222268169984eaf91df6f761e
Submitter: Jenkins
Branch: master

commit 6250825b6ad897d222268169984eaf91df6f761e
Author: Lin Hua Cheng <email address hidden>
Date: Mon Jan 20 22:22:42 2014 -0800

    Make table_actions style work with buttons

    Change-Id: I4470d50567e4fa92370ee8573047f5d717b74962
    Closes-Bug: #1269653

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → icehouse-3
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.