v3 credentials get blob format inconsistent

Bug #1269637 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Steven Hardy

Bug Description

The v3/credentials API specifies the blob response to be json, but due to bug #1259584, any credentials stored via the ec2tokens extension will incorrectly return a dict.

This makes it hard for clients (and in particular users migrating from ec2tokens to v3/credentials) to handle the blob data consistently as you don't know what format you're going to get.

Steven Hardy (shardy)
Changed in keystone:
assignee: nobody → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/66974

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/66974
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=6a051c19817292f4e221759f80d0b298aebbcee1
Submitter: Jenkins
Branch: master

commit 6a051c19817292f4e221759f80d0b298aebbcee1
Author: Steven Hardy <email address hidden>
Date: Wed Jan 15 21:47:52 2014 +0000

    v3 credentials, ensure blob response is json

    The v3/credentials API specifies the blob response to be json, but
    due to bug #1259584, any credentials stored via the ec2tokens extension
    will incorrectly return a dict. This makes it hard for clients (and
    in particular users migrating from ec2tokens to v3/credentials) to
    handle the blob data consistently, so add a workaround to ensure the
    response is always serialized as json if the existing DB contents is
    a dict instead of a json string.

    Change-Id: I340cdf4e565fdadacb41b39acace3948aafb9b92
    Related-Bug: #1259584
    Closes-Bug: #1269637

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
Steven Hardy (shardy)
tags: added: havana-backport-potential
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.