log rotation needed for guestagent

[Michael Yu]

Currently, there is no log rotation for the guest-agent.

Guest agent logs are stored in log_dir/log_file config gathered from /etc/trove/trove-guestagent.conf.sample.

Right now, it's set to /tmp/logfile.txt. This can fill up the root-disk on the guest-agent instance.

AFAIK, this requires setting up logrotate in the diskimage-builder elements.

Things to consider for this bug:
1) How much logrotate config should we give the user in guest-agent CONF? -=> Might be a better idea to just keep it simple and just add log_rotate_frequency and log_maxfiles in guest-agent CONF, and then once the guest-agent instance is up... he/she can manually add more configs to the logrotate CONF.
2) This leads me to the next point... this approach requires that diskimage-builder is called in order to create an image with the logrotate config setup (for any db instances to be provisioned with log rotation).

[Amrith Kumar (amrith)]

Updating importance to "Low" (bugscrub, 2014-10-23)

[Masaki Matsushita (mmasaki)]

We may use RotatingFileHandler.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/352257

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352257
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=f80dd43297fef5e3e4d5bf88995992c4af7ed16e
Submitter: Jenkins
Branch: master

commit f80dd43297fef5e3e4d5bf88995992c4af7ed16e
Author: Masaki Matsushita <email address hidden>
Date: Mon Aug 8 16:20:09 2016 +0900

    Add trove-guestagnet.conf sample for log rotation

    This change adds a configuration sample of guestagent
    to use log rotation.

    Change-Id: I2f2fb0d42f2f9d674daf3adff8725a365cc1a5b3
    Closes-Bug: #1269615

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.