Orders error message not being populated

Bug #1269594 reported by Chad Lung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
High
John Vrbanac

Bug Description

Steps to reproduce:

Using the orders endpoint I attempt the following:

POST:
http://localhost:9311/v1/12345/orders

BODY:
{ "secret": {"name": "secretname", "algorithm": "aes", "bit_length": 256, "mode": "cbc", "payload_content_type": "text/plain"}}

RETURNED ERROR:
400 Bad Request
{
    "title": "None"
}

In the "payload_content_type" I set the value to be "text/plain", currently only "application/octet-stream" is supported. The error message according to validators.py (line 233 approx.) should be: "Only 'application/octet-stream' supported" however it is "None"

Tags: verified
Revision history for this message
John Vrbanac (john.vrbanac) wrote :

Confirmed in dev and local environments.
Test Case: test_empty_error_message_on_invalid_order_creation

Changed in barbican:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → John Vrbanac (john.vrbanac)
tags: added: verified
tags: removed: verified
Changed in barbican:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/67362

Changed in barbican:
milestone: none → icehouse-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/67362
Committed: https://git.openstack.org/cgit/stackforge/barbican/commit/?id=4dd0b7b1c13b0bf03b2d25bcc26092acbdef9ad0
Submitter: Jenkins
Branch: master

commit 4dd0b7b1c13b0bf03b2d25bcc26092acbdef9ad0
Author: John Vrbanac <email address hidden>
Date: Thu Jan 16 21:21:04 2014 -0600

    Fixing issue around error messages not being populated

    The super constructor was getting called with a message of None and
    ignoring all of the remaining lines within the constructor that derive
    the correct message.

    (edit) Removing CR dependency

    Change-Id: Iad34da64c03db6a3c9759c00edf7b3b7ae53f0b4
    Closes-Bug: #1269594

Changed in barbican:
status: In Progress → Fix Committed
tags: added: verified
Steve Heyman (sheyman)
Changed in barbican:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.