Editors content gets replaced by other items content

[Vadim Peretokin]

In Mudlet/development, most likely due to the keyboard navigation change, an issue has started appearing where the content of another item would suddenly get replaced with the content of a previous item you were looking at. The exact sequence to repeat this problem still needs to be determined.

[Vadim Peretokin (vperetokin)]

The issue is that the save event is going off after the item switch event now:

slot_trigger_selected
slot_item_selected_save

[Vadim Peretokin (vperetokin)]

This implies that itemClicked is going off before currentItemChanged in the QTreeWidget.

[Vadim Peretokin (vperetokin)]

An easy way to reproduce this is to make an edit to a trigger, then click on the trigger below it. Going back, you'll see your triggers edit wasn't saved - the feature that saves stuff when you leave it got broken. So ideally, slot_item_selected_save would be going off first, and on some event like 'selection is changing'.

Current setup:
slot_trigger_selected = currentItemChanged
slot_item_selected_save = itemClicked

[Chris (chrismudlet)]

Yes, the logic for those things is rather explicit. Because you click it to
change it

sent from my phone
On Jan 22, 2014 2:55 PM, "Vadim Peretokin" <email address hidden> wrote:

> This implies that itemClicked is going off before currentItemChanged in
> the QTreeWidget.
>
> --
> You received this bug notification because you are subscribed to Mudlet.
> https://bugs.launchpad.net/bugs/1269582
>
> Title:
> Editors content gets replaced by other items content
>
> Status in Mudlet the MUD client:
> New
>
> Bug description:
> In Mudlet/development, most likely due to the keyboard navigation
> change, an issue has started appearing where the content of another
> item would suddenly get replaced with the content of a previous item
> you were looking at. The exact sequence to repeat this problem still
> needs to be determined.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1269582/+subscriptions
>

[Vadim Peretokin (vperetokin)]

The difficult part is making it save when you navigate away from that item, which is what should happen by design. We might have to make it save the previous item as given by currentItemChanged to save the content first and then to the change.

[Vadim Peretokin (vperetokin)]

Fixed in Mudlet/development.

[Vadim Peretokin (vperetokin)]

When you edit an item, don't save it yet, and hit Add item, the previous item does not get saved. save*() needs to be called whenever before the selection is manually changed, which includes this case.

[Stephen Lyons (slysven)]

Is this the same thing that I'm seeing where if I click to goto the Variable Display/Editor I can actually SEE it wiping all the content out of the Lua code entry window for the item I was on. It was making the scripts I'm currently trying to get working for a new (to me) Mud get like Swiss cheese - only happens when I go to the Variable tab as far as I can see.

[Stephen Lyons (slysven)]

I was wrong it does involve switching between all the tabs...

Can you give me a pointer to the Fix (where is it committed?) or patch?

[Chris (chrismudlet)]

So this is a change that vadi was working with I believe. I left it to him
to implement and haven't looked at the relevant code in a bit. Can you give
a step by step to reproduce it?

Sent from my phone.
On Jun 30, 2014 12:09 PM, "Stephen Lyons" <email address hidden>
wrote:

> I was wrong it does involve switching between all the tabs...
>
> Can you give me a pointer to the Fix (where is it committed?) or patch?
>
> --
> You received this bug notification because you are subscribed to Mudlet.
> https://bugs.launchpad.net/bugs/1269582
>
> Title:
> Editors content gets replaced by other items content
>
> Status in Mudlet the MUD client:
> Confirmed
>
> Bug description:
> In Mudlet/development, most likely due to the keyboard navigation
> change, an issue has started appearing where the content of another
> item would suddenly get replaced with the content of a previous item
> you were looking at. The exact sequence to repeat this problem still
> needs to be determined.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1269582/+subscriptions
>

[Vadim Peretokin (vperetokin)]

I don't recall if I've finished it. I think I solved one scenario and that
opened up another. The order that the events were happening in was a bit of
a can of worms.

On Tue, Jul 1, 2014 at 3:22 AM, Chris <email address hidden> wrote:

> So this is a change that vadi was working with I believe. I left it to him
> to implement and haven't looked at the relevant code in a bit. Can you give
> a step by step to reproduce it?
>
> Sent from my phone.
> On Jun 30, 2014 12:09 PM, "Stephen Lyons" <email address hidden>
> wrote:
>
> > I was wrong it does involve switching between all the tabs...
> >
> > Can you give me a pointer to the Fix (where is it committed?) or patch?
> >
> > --
> > You received this bug notification because you are subscribed to Mudlet.
> > https://bugs.launchpad.net/bugs/1269582
> >
> > Title:
> > Editors content gets replaced by other items content
> >
> > Status in Mudlet the MUD client:
> > Confirmed
> >
> > Bug description:
> > In Mudlet/development, most likely due to the keyboard navigation
> > change, an issue has started appearing where the content of another
> > item would suddenly get replaced with the content of a previous item
> > you were looking at. The exact sequence to repeat this problem still
> > needs to be determined.
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/mudlet/+bug/1269582/+subscriptions
> >
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1269582
>
> Title:
> Editors content gets replaced by other items content
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1269582/+subscriptions
>

[Stephen Lyons (slysven)]

Use the Editor to work on a script for an Alias/Script or Trigger, take a copy of the contents of the working area on the right (e.g. under all the trigger settings stuff on THAT tab) so that you can replace them. Now click on one of the other tabs (originally I thought it was just the variable one but it may not be), before the view changes to the one for the selected function I can actually see the working area be cleared, and when I switch back to that editor view it is still on the particular leaf that I left, the settings at the top of the right side are retained BUT THE CONTENTS of the editing area ARE GONE.

Now I reserve the right to mess up my copy of the codebase (I'm currently working on my mudletDev_fixTType branch) but if this a bug that is in Chris7/Mudlet2 mudletDev then it might well be appearing elsewhere...

[Stephen Lyons (slysven)]

Maybe I'm the early bird that got the first worm out of the can that Vadim refers to. 8-)

[stratumnine (stratumnine)]

I'm not sure if this is related but I have had code in the editor vanish as well. Names of group items also end up getting truncated.

Steps to reproduce:

Create a group item and give it a name.
Click add group item to make the new item a sub-item of the group you just created.
The parent item's title will be truncated (and any code inside it can vanish as well).

[Vadim Peretokin (vperetokin)]

Which version are you using?

On Fri, Aug 15, 2014 at 1:18 AM, Brian Salcedo <email address hidden> wrote:

> I'm not sure if this is related but I have had code in the editor vanish
> as well. Names of group items also end up getting truncated.
>
> Steps to reproduce:
>
> Create a group item and give it a name.
> Click add group item to make the new item a sub-item of the group you just
> created.
> The parent item's title will be truncated (and any code inside it can
> vanish as well).
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1269582
>
> Title:
> Editors content gets replaced by other items content
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1269582/+subscriptions
>

[Ahmed Charles (ahmedcharles)]

This is fixed by: https://github.com/Mudlet/Mudlet/pull/60

Note, keyboard navigation doesn't work anymore, but this bug isn't about that and keyboard navigation not working isn't a regression, and therefore, it's less urgent.