method writes the assignment statements after unconditional return

Bug #1269437 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Wishlist
Sushil Kumar

Bug Description

trove/tests/util/users.py contains ServiceUser.__str__ which is assigning values after a return statement.
This assignment has no use.

Also it assigns the values which are not available in the method.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/66849

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Changed in trove:
importance: Undecided → Low
Changed in trove:
importance: Low → Wishlist
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/66849
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=cd2f6f0a515bcbac7b207843cac8259b21a2c450
Submitter: Jenkins
Branch: master

commit cd2f6f0a515bcbac7b207843cac8259b21a2c450
Author: Sushil Kumar <email address hidden>
Date: Wed Jan 15 14:16:29 2014 +0000

    Cleans up ServiceUser.__str__ method

    Reasons:
    - ServiceUser.__str__ in trove/tests/util/users.py contains code
      after the return statement.
    - This code after unconditional return statement has no use.
    - Thus, ServiceUser.__str__ method needs cleanup.

    Changes:
    - Removes the statements after return statement.
    - Adds tenant name to the __str__.

    Change-Id: Ic5e35969f435e01d94da7eb434cd8de19e2c9873
    Closes-Bug: #1269437

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.