long press latching buttons not working in trunk

[Owen Williams]

since the widget changes, pressing and holding the sync button does not keep the button lit, although sync mode is enabled

[RJ Skerry-Ryan (rryan)]

This is because of the way they are skinned in your Sync skin:

<Connection>
  <ConfigKey>[Channel1],sync_enabled</ConfigKey>
  <EmitOnPressAndRelease>true</EmitOnPressAndRelease>
  <ButtonState>LeftButton</ButtonState>
</Connection>
<Connection>
  <ConfigKey>[Channel1],beatsync_tempo</ConfigKey>
  <EmitOnPressAndRelease>true</EmitOnPressAndRelease>
  <ButtonState>RightButton</ButtonState>
</Connection>

Both of these connections are <ConnectValueToWidget> true because this is the default. The new logic for auto-selecting a display connection is that the last connection that is connected to the widget is the display connection. I guess we need something more complex.

Maybe it should be the last of any <LeftButton> or no button connection and if none exist, then the right button connection.

[Owen Williams (ywwg)]

Since right button clicks are always alternative functionality, should those ever be the display connection?

[Daniel Schürmann (daschuer)]

For me the display connection should be always default to the first LeftButton connection if no Display connection is explicit set.
I can prepare a fix. I am planning to work on the Indicator in cdj today so I can fix that.
@RJ: OK?

[RJ Skerry-Ryan (rryan)]

@daschuer -- as we discussed before that would break hotcues.

I think the right behavior is:

1) The last of left or no-button connections that are connected to the widget.
2) If none exist, a right button connection if it is connected to the widget.

This supports Owen's sync button definition above and the hotcue buttons in all existing Mixxx skins. I'll fix this in master.

[Daniel Schürmann (daschuer)]

Fine, thank you.

[RJ Skerry-Ryan (rryan)]

Fixed in https://github.com/mixxxdj/mixxx/commit/086b971ebe72e6fc272c2809da5f77f388f0029a

[Daniel Schürmann (daschuer)]

Thank you!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7268