Cinder

VMware: Problems with vmdk driver exception logging

Bug #1269345 reported by Vipin Balachandran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Vipin Balachandran
Cinder 2015.1.0 "kilo"

Bug Description

At many places in the vmdk driver, logging.exception is called with a formatted string containing info of the currently handled exception. This is unnecessary as the exception logging method adds the exception info to the logging message before emitting it at level ERROR.

Tags: drivers vmware
Subbu (subramanian-neelakantan)
Changed in cinder:
importance: Undecided → Low
assignee: nobody → Subbu (subramanian-neelakantan)
Vipin Balachandran (vbala)
tags: added: vmware
Subbu (subramanian-neelakantan)
Changed in cinder:
status: New → Confirmed
Vipin Balachandran (vbala)
tags: added: drivers
removed: driver vmdk
summary: - Problems with vmdk driver exception logging
+ VMware: Problems with vmdk driver exception logging
Vipin Balachandran (vbala)
Changed in cinder:
assignee: Subbu (subramanian-neelakantan) → Vipin Balachandran (vbala)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/114981

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/114981
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7ac4fc76f2d777fd4e0ec4245eaf989f99917be2
Submitter: Jenkins
Branch: master

commit 7ac4fc76f2d777fd4e0ec4245eaf989f99917be2
Author: Vipin Balachandran <email address hidden>
Date: Thu Aug 14 20:36:20 2014 +0530

    VMware: Handle exceptions raised by image update

    Exceptions raised by glance image update are not handled while writing
    to image. This results in volume being stuck in uploading state for
    a long time even after image transfer failure. This patch fixes the
    exception handling.

    Change-Id: I7651c96968caa49c5421d68ee4dbe9e55f7f53b1
    Closes-Bug: #1357239
    Partial-Bug: #1269345

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163231

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/163231
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=15ee40e627f236011c9117fa65748fe4f03843d1
Submitter: Jenkins
Branch: master

commit 15ee40e627f236011c9117fa65748fe4f03843d1
Author: Vipin Balachandran <email address hidden>
Date: Wed Mar 11 04:53:02 2015 +0530

    VMware: Fix exception logging

    At some places, logging.exception is called with a formatted
    string containing info of the current exception. The exception
    info in the log message is redundant since logging.exception
    always logs the current exception.

    Change-Id: I4ec6b3dabf6e0f2c22b06bd65d765eaa453b819d
    Closes-Bug: #1269345

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.