incorrect PID matching for neutron-*-agent in ocf scripts

[Sergey Vasilenko]

Its possible in some situations for the pgrep to return process ID from the wrong process. After this Pacemaker kill one of the agents when it thinks it is no longer running.

We should use pgrep with -o for catch only oldest's process ID.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/67101

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/4.0
Review: https://review.openstack.org/67118

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/67118
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=fbfe4c087476092fb7a4b93a95166594f5e58c57
Submitter: Jenkins
Branch: stable/4.0

commit fbfe4c087476092fb7a4b93a95166594f5e58c57
Author: Sergey Vasilenko <email address hidden>
Date: Thu Jan 16 14:36:03 2014 +0400

    Fixed incorrectt PID matching for neutron-*-agents

    Change-Id: I15ea6cce54135f9d91080c736ba496c3002aa182
    Closes-bug: #1269334

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/67101
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=c677020ed7412b6eac092e795b84fb7a13cb12e1
Submitter: Jenkins
Branch: master

commit c677020ed7412b6eac092e795b84fb7a13cb12e1
Author: Sergey Vasilenko <email address hidden>
Date: Thu Jan 16 14:36:03 2014 +0400

    Fixed incorrectt PID matching for neutron-*-agents

    Change-Id: I15ea6cce54135f9d91080c736ba496c3002aa182
    Closes-bug: #1269334

[Pavel Vaylov (pvaylov)]

Does this solution tested on live 4.0 environment ?
After I've made changes in 4 ocf files and restarted corosync I can start dhcp and l3 agents only by:

"crm_resource --resource p_neutron-l3-agent --force-start"

"crm status" does not show agents as "started"

I'm not sure if it related to patch or not.
Will continue debugging.

[Pavel Vaylov (pvaylov)]

I was able to start dhcp and l3 agents.

By some reason (due my experiments I think) "clone_p_neutron-metadata-agent" has been stopped.
But dhcp and l3 agents depends on "clone_p_neutron-metadata-agent".

[root@node-6 ~]# crm_resource --resource p_neutron-dhcp-agent -A
* p_neutron-dhcp-agent
    clone_p_neutron-metadata-agent (score=INFINITY, id=dhcp-with-metadata)
    clone_p_neutron-openvswitch-agent (score=INFINITY, id=dhcp-with-ovs)
    p_neutron-l3-agent (score=-100, id=dhcp-without-l3)
        clone_p_neutron-metadata-agent (id=l3-with-metadata - loop)
        clone_p_neutron-openvswitch-agent (id=l3-with-ovs - loop)

After I've started "clone_p_neutron-metadata-agent" dhcp and l3 agents started to.