Don't waste CPU time on the master or headphone output if no device is enabled for master or headphone.

Bug #1269139 reported by RJ Skerry-Ryan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Daniel Schürmann

Bug Description

If no master or headphone device is selected, we should just not calculate the master or headphone output.

(Depends on being able to detect when the sidechain is active).

Tags: performance
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

We should also provide COs that represent when a master or headphone output is active so we could hide or disable the relevant parts of the mixer section.

Changed in mixxx:
milestone: none → 1.12.0
importance: Undecided → Low
tags: added: performance
Revision history for this message
Daniel Schürmann (daschuer) wrote :

I will try to fix this along with Bug #1203249.

Changed in mixxx:
status: New → Confirmed
assignee: nobody → Daniel Schürmann (daschuer)
Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
Daniel Schürmann (daschuer) wrote :

It is hard to find out from the hardware preferences if master and/or headphone is required, because recording feature and headphone mix.
I will add dedicated preference option, to disable master mix.

Revision history for this message
Daniel Schürmann (daschuer) wrote :
Revision history for this message
Daniel Schürmann (daschuer) wrote :
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Owen Williams (ywwg) wrote :

I guess I would prefer to revert this unless there's a compelling usecase or performance implication. It's confusing and there are lots of situations where a master mix is required even if there's no master output

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7259

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.