Dependency on pyudev is unnecessary

Bug #1269040 reported by Darragh O'Reilly
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Darragh O'Reilly
Havana
Fix Released
Undecided
Unassigned

Bug Description

The pyudev package is only used in linuxbridge_neutron_agent.py to get a list of virtual network devices. This can be done without pyudev.

Changed in neutron:
status: New → In Progress
assignee: nobody → Darragh O'Reilly (darragh-oreilly)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/66609

Changed in neutron:
assignee: Darragh O'Reilly (darragh-oreilly) → Anita Kuno (anteaya)
Changed in neutron:
assignee: Anita Kuno (anteaya) → Darragh O'Reilly (darragh-oreilly)
Revision history for this message
Darragh O'Reilly (darragh-oreilly) wrote :

The patch fixes the problem where testr cannot import the linuxbridge agent module because pydev was not in requirements.txt. You get:

Non-zero exit code (2) from test listing. stdout='\xb3)\x01@\x86@{neutron.tests.unit.agent.linux.test
         << skip pages of useless information >>
import errors4neutron.tests.unit.linuxbridge.test_lb_neutron_agent\x85\xc5\x1a\\', stderr=None
error: testr failed (3)

Revision history for this message
Darragh O'Reilly (darragh-oreilly) wrote :

There is a bug for the format for the error output here https://bugs.launchpad.net/testrepository/+bug/1271133

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/66609
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dfa4112400173d2fc1c9bbe2bc8028d720fd7168
Submitter: Jenkins
Branch: master

commit dfa4112400173d2fc1c9bbe2bc8028d720fd7168
Author: Darragh O'Reilly <email address hidden>
Date: Tue Jan 14 15:02:17 2014 +0000

    Remove pyudev dependency

    pyudev was only used by the linuxbridge-agent to get the list
    of virtual network devices. This can be got from /sys instead.
    This patch fixes the problem where testr could not import the
    lb-agent module because pyudev was not in requirements.txt.

    Change-Id: I0a78c91e97de4413f2ecf6fb56d2ff61b36baa78
    Closes-Bug: 1269040

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
importance: Undecided → Wishlist
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/86506

Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (stable/havana)

Reviewed: https://review.openstack.org/86506
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ac8c83653bad3f9d91dd539271d110e3f5dc5e04
Submitter: Jenkins
Branch: stable/havana

commit ac8c83653bad3f9d91dd539271d110e3f5dc5e04
Author: Darragh O'Reilly <email address hidden>
Date: Tue Jan 14 15:02:17 2014 +0000

    Remove pyudev dependency

    pyudev was only used by the linuxbridge-agent to get the list
    of virtual network devices. This can be got from /sys instead.
    This patch fixes the problem where testr could not import the
    lb-agent module because pyudev was not in requirements.txt.

    Cherry-picked from dfa4112400173d2fc1c9bbe2bc8028d720fd7168

    Change-Id: I0a78c91e97de4413f2ecf6fb56d2ff61b36baa78
    Closes-Bug: 1269040
    Closes-Bug: 1305428

tags: added: in-stable-havana
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.