Creating an image without container format queues image and fails with 400

[Jon Bernard]

Description of problem:

Creating an image from CLI without --container format queued the image and fails with 400.

Request returned failure status.
400 Bad Request
Invalid container format 'None' for image.
    (HTTP 400)

How reproducible:
# glance --debug image-create --name cirros --disk-format qcow2 --file /tmp/cirros-image.qcow2 --progress
<snip>
[=============================>] 100%

HTTP/1.1 400 Bad Request
date: Tue, 07 Jan 2014 14:13:54 GMT
content-length: 64
content-type: text/plain; charset=UTF-8
x-openstack-request-id: req-11b4ecad-3a8d-4e44-9c37-a4d843805889

400 Bad Request

Invalid container format 'None' for image.

# glance image-list
+-----------------------------------------------------------+-----------+-----------------+------------------------+----------------+-----------+
| ID | Name | Disk Format | Container Format | Size | Status |
+-----------------------------------------------------------+-----------+-----------------+------------------------+----------------+-----------+
| b2490dd2-b535-4b98-8647-cca428a63e01 | cirros | qcow2 | | 307962880 | queued |
+-----------------------------------------------------------+-----------+-----------------+------------------------+----------------+-----------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/66386

[Erno Kuvaja (jokke)]

iirc this is fixed

[Pranali Deore (pranali-deore)]

This bug is reproducible in V2 api also.

Steps to reproduce:

 $glance --os-image-api-version 2 image-create --name Test --disk-format qcow2

 $glance --os-image-api-version 2 image-upload 21c74416-9fea-4160-98c0-867f82aa58e9 --file /home/openstack/aaaaa.py

As per discussion in glance weekly meeting, no fix is required for V1 api as V1 api will be deprecated during Kilo release, still we need to fix this bug for V2 api.

Please suggest.

[Jon Bernard (jbernard)]

Ok, I'll update my patch to target v2.

[Jon Bernard (jbernard)]

@pranali-deore Ah, i missed that you assigned to yourself, if you'd like to do the work that's fine with me - just let me know.

[Pranali Deore (pranali-deore)]

Difference between v1 and v2 api for this issue is,

For V1 :
If container format is not provided and disk-format is one of amazon format(ami, ari, aki), then image gets created with container-format = disk-format, else image goes into 'queued' state.

For V2 :
If container format or disk format is not provided then glance api raises appropriate error at the time of uploading image,

Steps:
 $glance --os-image-api-version 2 image-create --name Test

 $glance --os-image-api-version 2 image-update d43b2c0c-327e-4cab-9943-bbc093381fca --disk-format ami

 $glance --os-image-api-version 2 image-upload d43b2c0c-327e-4cab-9943-bbc093381fca --file /home/openstack/aaaaa.py

Then it raises 400 HTTPBadRequest with below error log,

"Cannot save data for image d43b2c0c-327e-4cab-9943-bbc093381fca:
Property container_format must be set prior to saving data. upload /opt/stack/glance/glance/api/v2/image_data.py:94"

IMO this is correct behaviour for V2.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jon Bernard (<email address hidden>) on branch: master
Review: https://review.openstack.org/66386

[Jun Hong Li (junhongl)]

Yes, I've verified the steps Pranali said in comment #6, i agree that the existing v2 behavior is what the bug reporter expected when creating this bug. So I suggest we can close this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/181130

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/181130
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=ac9f373cd0402f90eee30a6f3944dfa10f948216
Submitter: Jenkins
Branch: master

commit ac9f373cd0402f90eee30a6f3944dfa10f948216
Author: Mike Fedosin <email address hidden>
Date: Thu May 7 22:05:42 2015 +0300

    Fix delayed activation without disk and containers formats

    If we want to perform a delayed activation of an image without
    providing disk format or container format, Glance tries to
    upload a file and fails with 400 error.

    This code handles this situation by checking that no sources
    were provided, and returns information about the image before
    starting the upload.

    Change-Id: Id6f81df9bb43697b0d694528b010bb3c7c9bedb3
    Closes-Bug: #1268680