Unable to delete stacks created under admin. users

[Mohammed Naser]

If you create a stack under an administrator user, it will work fine. If you attempt to delete that stack, it will fail. The reason that it will fail is that admin users can read deleted servers

https://github.com/openstack/heat/blob/master/heat/engine/resources/nova_utils.py#L207

This means that this will run forever and never raise that exception, because it will always return a server.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/66234

[Angus Salkeld (asalkeld)]

This has been fixed here: https://github.com/openstack/heat/blob/master/heat/engine/clients/os/nova.py#L318
Marking as fixed.

[Angus Salkeld (asalkeld)]

originally fixed by randall here: https://github.com/openstack/heat/commit/eb4956aa17da7c575ede3856b2cfc8c91ba78355