Pep8 1.4.6+ new warnings

Bug #1267994 reported by Dirk Mueller
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Dirk Mueller
python-keystoneclient
Fix Released
Wishlist
Dirk Mueller

Bug Description

Pep8 1.4.8 fixed a few bugs in the pep8 checks that would trigger frequently when used on OpenStack:

  * Correctly report other E12 errors when E123 is ignored. (Issue #103)
  * Accept both styles of closing bracket indentation for hanging indent.
    Do not report error E123 in the default configuration. (Issue #103)
  * Fix E701, E702 and E703 not detected sometimes. (Issue #196)
  * Fix E122 not detected in some cases. (Issue #201 and #208)

Various code in OpenStack needs to be updated to be passing against pep8 1.4.6+ in order to be able to raise the version requirement.

Changed in trove:
assignee: nobody → Dirk Mueller (dmllr)
status: New → In Progress
Changed in python-keystoneclient:
assignee: nobody → Dirk Mueller (dmllr)
importance: Undecided → Wishlist
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/62152
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=e2c10c1ed32a0bbef1de004f3b8b74883eefed06
Submitter: Jenkins
Branch: master

commit e2c10c1ed32a0bbef1de004f3b8b74883eefed06
Author: Dirk Mueller <email address hidden>
Date: Sat Dec 14 12:55:29 2013 +0100

    Fixup indentation errors found by Pep8 1.4.6+

    Closes-Bug: #1267994

    Change-Id: I2662c863e21baa6a290311ec8eb12a01193eed94

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/52488
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=fc1f75aa5121f92319c3f9eb8906ad4d7e969c7c
Submitter: Jenkins
Branch: master

commit fc1f75aa5121f92319c3f9eb8906ad4d7e969c7c
Author: Dirk Mueller <email address hidden>
Date: Thu Oct 17 21:38:51 2013 +0200

    Fix E12x warnings found by Pep8 1.4.6

    These are missed due to bugs in 1.4.5.

    Closes-Bug: #1267994
    Change-Id: Ic7b37abf757a9b7b0c8306c941949dee93b83e08

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.5.0
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.