Fixed metric_index causes ValueError in ip_lib

Bug #1267790 reported by Arata Notsu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Arata Notsu

Bug Description

ip_lib.IpRouteCommand.get_gateway() raises ValueError to default_route_line like

default via 192.168.99.1 proto static

since it wrongly assumes that the 5th word is a value metric (in the example above, it is "static").

Tags: l3-ipam-dhcp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/65917

Changed in neutron:
assignee: nobody → Arata Notsu (arata776)
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
milestone: none → icehouse-3
tags: added: l3-ipam-dhcp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/65917
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5b5ba869aa4680bcfa7544c4e718cb5a5dc9c168
Submitter: Jenkins
Branch: master

commit 5b5ba869aa4680bcfa7544c4e718cb5a5dc9c168
Author: Arata Notsu <email address hidden>
Date: Fri Jan 10 19:54:10 2014 +0900

    Fix ValueError in ip_lib.IpRouteCommand.get_gateway()

    As metric is not necessarily the 5th word of the gateway line, the
    method should search the string 'metric' in the line and pick the next
    word as the metric value.

    Change-Id: I2663ddbae82f80b912b364c07f9ab92c5b90b718
    Closes-Bug: #1267790

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.