Duplicated classes in lbaas.py and vpn.py

Bug #1267779 reported by Tatiana Ovchinnikova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Tatiana Ovchinnikova

Bug Description

There are duplicate classes AttributeDict in Pool and Member classes of lbaas.py and in VPNService and IPSecSiteConnection classes of vpn.py. It would be nice to move them to e.g. horizon.utils where the code could be reused.

Changed in horizon:
assignee: nobody → Tatiana Mazur (tmazur)
Revision history for this message
Akihiro Motoki (amotoki) wrote :

The very basic idea for LBaaS is here: http://paste.openstack.org/show/60944/,
but the following in openstack_dashboard/dashboards/project/loadbalancers/tabs.py is redundant.

   for p in pools:
       p.readable(self.tab_group.request)

Another idea is to move this logic to pool_list/member_list in api/lbaas.py. (This approach is similar to the one in fwaas.py)
If there is a case where expanding names is unnecessary, adding expand_name=True/False arugment to pool/member_list is one option.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/66144

Changed in horizon:
status: New → In Progress
summary: - Duplicated classes in lbaas.py and vpnaas.py
+ Duplicated classes in lbaas.py and vpn.py
description: updated
Changed in horizon:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/66144
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5391659fdfd0d86165ed743255d0d167c992375e
Submitter: Jenkins
Branch: master

commit 5391659fdfd0d86165ed743255d0d167c992375e
Author: Tatiana Mazur <email address hidden>
Date: Fri Jan 10 22:38:14 2014 +0400

    Removing duplicated classes from lbaas.py and vpn.py

    This patch removes duplicated classes AttributeDict from
    api/lbaas.py and api/vpn.py. Additional attributes are
    added as needed in 'list' and 'get' methods.

    Closes-Bug: #1267779
    Change-Id: I47d8eb5fc9bd0767ac85a7c65d394ab2b7a2ea5d

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.