Duplicated classes in lbaas.py and vpn.py
Bug #1267779 reported by
Tatiana Ovchinnikova
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Wishlist
|
Tatiana Ovchinnikova |
Bug Description
There are duplicate classes AttributeDict in Pool and Member classes of lbaas.py and in VPNService and IPSecSiteConnection classes of vpn.py. It would be nice to move them to e.g. horizon.utils where the code could be reused.
Changed in horizon: | |
assignee: | nobody → Tatiana Mazur (tmazur) |
summary: |
- Duplicated classes in lbaas.py and vpnaas.py + Duplicated classes in lbaas.py and vpn.py |
description: | updated |
Changed in horizon: | |
importance: | Undecided → Wishlist |
Changed in horizon: | |
milestone: | none → icehouse-3 |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | icehouse-3 → 2014.1 |
To post a comment you must log in.
The very basic idea for LBaaS is here: http:// paste.openstack .org/show/ 60944/, dashboard/ dashboards/ project/ loadbalancers/ tabs.py is redundant.
but the following in openstack_
for p in pools:
p.readable( self.tab_ group.request)
Another idea is to move this logic to pool_list/ member_ list in api/lbaas.py. (This approach is similar to the one in fwaas.py) name=True/ False arugment to pool/member_list is one option.
If there is a case where expanding names is unnecessary, adding expand_