docker driver exposes public methods outside of driver interface - should be private

Bug #1267664 reported by Erica Windisch
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Erica Windisch

Bug Description

The following methods are public and should be prefixed with a _ to indicate that they are private:

     is_daemon_running
     find_container_by_name
     get_available_resource

Tags: docker
Matt Riedemann (mriedem)
tags: added: docker
Changed in nova:
status: New → Triaged
Changed in nova:
status: Triaged → In Progress
assignee: nobody → Swapnil Kulkarni (coolsvap)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/67417

Revision history for this message
Erica Windisch (ewindisch) wrote :

My fix / review didn't get properly linked:
https://bugs.launchpad.net/nova/+bug/1267664

Revision history for this message
Erica Windisch (ewindisch) wrote :

I meant to link my branch: https://review.openstack.org/#/c/65837/

Changed in nova:
assignee: Swapnil Kulkarni (coolsvap) → Eric Windisch (ewindisch)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/65837
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=58d7eeede1e2912ab250fd306c85ca1a05de2fbc
Submitter: Jenkins
Branch: master

commit 58d7eeede1e2912ab250fd306c85ca1a05de2fbc
Author: Eric Windisch <email address hidden>
Date: Thu Jan 9 19:46:14 2014 -0500

    Prefix private methods with _ in docker driver

    Private methods should be prefixed with a _ for
    clarity. Although most private methods were
    marked this way, a few were not.

    Renames and marks private:
     is_daemon_running
     find_container_by_name
     get_available_resource

    Closes-Bug: #1267664

    Change-Id: Ifc6818b7620af972cc0eec6f9ef43610456895f1

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.