ML2 Cisco Nexus MD: Improve Unit Test Coverage

Bug #1267481 reported by Rich Curran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Rich Curran

Bug Description

Improve unit test coverage for:
neutron/plugins/ml2/drivers/cisco/
modules.
Current coverage info:
neutron/plugins/ml2/drivers/cisco/nexus_models_v2
13 1 4 0 94% 35
neutron/plugins/ml2/drivers/cisco/nexus_network_driver
111 20 20 4 82% 50, 74, 111-114, 159-162, 166-169, 206-209, 212-215
neutron/plugins/ml2/drivers/cisco/credentials_v2
27 6 4 0 81% 38-42, 47, 64-65, 71
neutron/plugins/ml2/drivers/cisco/mech_cisco_nexus
110 17 29 14 78% 76-83, 98, 119-122, 134-139, 151, 176
neutron/plugins/ml2/drivers/cisco/config
18 3 10 4 75% 58, 64-65

(Also see similar fixes made to plugin/cisco modules.
https://review.openstack.org/#/c/57100/
https://review.openstack.org/#/c/60370/
https://review.openstack.org/#/c/58882/)

Rich Curran (rcurran)
Changed in neutron:
assignee: nobody → Rich Curran (rcurran)
description: updated
Rich Curran (rcurran)
description: updated
tags: added: ml2-unit-test-coverage
Rich Curran (rcurran)
Changed in neutron:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88695

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/88695
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5ca43cd39431b49d347a6ff8637dd6388266e03a
Submitter: Jenkins
Branch: master

commit 5ca43cd39431b49d347a6ff8637dd6388266e03a
Author: Rich Curran <email address hidden>
Date: Fri Apr 18 17:09:08 2014 -0400

    ML2 Cisco Nexus MD: Improve Unit Test Coverage

    Improve unit test coverage for:
    neutron/plugins/ml2/drivers/cisco/ modules.

    Current coverage info:
    neutron/plugins/ml2/drivers/cisco/nexus/nexus_models_v2 65%
    neutron/plugins/ml2/drivers/cisco/nexus/nexus_network_driver 82%
    neutron/plugins/ml2/drivers/cisco/nexus/credentials_v2 81%
    neutron/plugins/ml2/drivers/cisco/nexus/mech_cisco_nexus 78%
    neutron/plugins/ml2/drivers/cisco/nexus/config 75%

    With these updates:
    neutron/plugins/ml2/drivers/cisco/nexus/mech_cisco_nexus 99%
    neutron/plugins/ml2/drivers/cisco/nexus/nexus_db_v2 99%
    neutron/plugins/ml2/drivers/cisco/nexus/nexus_models_v2 65%
    neutron/plugins/ml2/drivers/cisco/nexus/nexus_network_driver 98%
    neutron/plugins/ml2/drivers/cisco/nexus/config 100%

    NB: nexus_models_v2.py consists of database definitions and two
    customization methods, __repr__ and __eq__.

    Change-Id: I0de1cb9e71adffff698e37c8bec5497b88f0f0cd
    Closes-Bug: 1267481

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.