Change default value of resize_confirm_window to -1

Bug #1267294 reported by Guangya Liu (Jay Lau)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Opinion
Wishlist
Guangya Liu (Jay Lau)

Bug Description

Now the default value of resize_confirm_window is 0, 0 means auto confirm was disabled.

For some cases, admin might want to confirm immediately, but the minimum value is 1 which means that we need to wait at least one second.

Also the auto confirm resize logic was in a periodic task, if the periodic task interval was 60s, and even if we set resize_confirm_window as 1 we might still need to wait 60s before auto confirm.

So we should set the default value of resize_confirm_window to -1 which means auto confirm was disabled and 0 means auto confirm immediately

Changed in nova:
assignee: nobody → Jay Lau (jay-lau-513)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/65637

Changed in nova:
status: New → In Progress
Revision history for this message
Joe Gordon (jogo) wrote :

this is a backwards incompatible change as is.

Changed in nova:
status: In Progress → Incomplete
Sean Dague (sdague)
Changed in nova:
status: Incomplete → Opinion
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.