Certain redirects change the HTTP method
Bug #1267286 reported by
Jamie Lennox
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| python-keystoneclient |
Fix Released
|
Wishlist
|
Jamie Lennox | ||
Bug Description
Requests optimizes itself for the web case and so there are situations where if you forward a POST request it will change it to a GET request. https:/
This can make sense for web forms but it is a problem if you forward your API calls. We should compensate for this because we don't care about the forwarding type for APIs.
If we strip this control from the requests lib then we should provide similar levels of control in our solution.
| Changed in python-keystoneclient: | |
| assignee: | nobody → Jamie Lennox (jamielennox) |
| status: | New → In Progress |
| Changed in python-keystoneclient: | |
| importance: | Undecided → Wishlist |
| status: | In Progress → New |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to python-keystoneclient (master) | #1 |
| Changed in python-keystoneclient: | |
| status: | In Progress → Fix Committed |
| Changed in python-keystoneclient: | |
| milestone: | none → 0.4.2 |
| Changed in python-keystoneclient: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 165da791af5e03b
Author: Jamie Lennox <email address hidden>
Date: Thu Dec 5 18:11:39 2013 +1000
Controllable redirect handling
The requests library handles redirects as a browser would, which has the problem
that forwarding a POST will convert it to a GET. This is not necessarily
intuitive for an API. Handle all redirection manually and provide some
control over how far redirection can go.
Closes-Bug: 1267286
Change-Id: I24596a9c39cc29