CSS lang pseudo-class matching should be case-insensitive

Bug #1267118 reported by Carl Hoffman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
Martin Owens
libcroco
Confirmed
Low

Bug Description

Section 5.11.4 of the CSS 2.1 specification reads "The matching of C against the element's language value is performed case-insensitively." Both Chrome and Firefox operate this way.

In Inkscape 0.48, the tag <text class="abc" lang="JA"> will match the selector text.abc:lang(JA) but not the selector text.abc:lang(ja).

Tags: css svg
jazzynico (jazzynico)
tags: added: css svg
Revision history for this message
Martin Owens (doctormo) wrote :

This is an outstanding error in libcroco which is still there in upstream 0.6.8, I've patched our version of the code in revision 12887 to do a case-insensitive match on the lang pseudo-class.

I'm attaching my test file which contains three text elements. The first 'Lower case' is green, the second is 'Jap' is a false-positive indicator while the bottom 'Upper case' is the false-negative reported here and is red before the patch and green after it.

Changed in inkscape:
assignee: nobody → Martin Owens (doctormo)
status: New → Fix Committed
Revision history for this message
Martin Owens (doctormo) wrote :
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

@Martin - Is this bug in the upstream croco tracker? We should really forward the patch to them.

Revision history for this message
Alex Valavanis (valavanisalex) wrote :
Revision history for this message
Martin Owens (doctormo) wrote :
Changed in libcroco:
importance: Unknown → Low
status: Unknown → New
su_v (suv-lp)
Changed in inkscape:
importance: Undecided → Medium
milestone: none → 0.91
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
Changed in libcroco:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.