Keystone spamming log with deprecation warnings

Bug #1266812 reported by Adam Young
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
High
Brant Knudson
oslo-incubator
Fix Released
High
Brant Knudson

Bug Description

ONce the startup finishes, the log is currently filled with line after line of

2014-01-07 16:55:04.871 29654 WARNING keystone.common.utils [-] Deprecated: v2 API is deprecated as of Icehouse in favor of v3 API and may be removed in K.

Revision history for this message
Attila Fazekas (afazekas) wrote :
Changed in keystone:
status: New → Confirmed
Revision history for this message
Brant Knudson (blk-u) wrote :

The fix needs to be made in oslo and then synced to keystone.

Changed in oslo:
assignee: nobody → Brant Knudson (blk-u)
Changed in keystone:
assignee: nobody → Brant Knudson (blk-u)
Changed in oslo:
status: New → In Progress
Revision history for this message
Dolph Mathews (dolph) wrote :

Link to oslo patch?

Revision history for this message
Brant Knudson (blk-u) wrote :

https://review.openstack.org/#/c/67668/ and https://review.openstack.org/#/c/67664

-- not sure why they weren't linked because I put "Closes-Bug: #1266812" on it.

Changed in oslo:
milestone: none → icehouse-3
importance: Undecided → High
Dolph Mathews (dolph)
Changed in keystone:
milestone: none → icehouse-3
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/67664
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=fdfbced7fe76920e112f5725123b5b1db31903e0
Submitter: Jenkins
Branch: master

commit fdfbced7fe76920e112f5725123b5b1db31903e0
Author: Brant Knudson <email address hidden>
Date: Tue Jan 28 13:38:46 2014 -0600

    Enhance tests for LOG.deprecated

    The tests for LOG.deprecated were incorrect because they were
    clearing the log buffers on every call.

    When this is corrected, it shows that LOG.deprecated is not working
    as expected since it logs multiple times when the test indicates
    that it should only log once.

    Change-Id: Ic0e4925c372e5948c2140daa07ab3362fb25a306
    Partial-Bug: #1266812

Changed in oslo:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/67668
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=52b64466177b58c8e80bc72c5ce1e940782c969a
Submitter: Jenkins
Branch: master

commit 52b64466177b58c8e80bc72c5ce1e940782c969a
Author: Brant Knudson <email address hidden>
Date: Tue Jan 28 14:21:28 2014 -0600

    Fix deprecated messages sent multiple times

    Calling LOG.deprecated('...') multiple times with the same log
    message was causing the message to be logged multiple times. The
    message should only have been logged once.

    Change-Id: Ieab0bf2656761759966cf16f1de05bcb41cd1be5
    Closes-Bug: #1266812

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73026

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/73026
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=40cff9016629374c8418088f20ff61a9201076f8
Submitter: Jenkins
Branch: master

commit 40cff9016629374c8418088f20ff61a9201076f8
Author: Brant Knudson <email address hidden>
Date: Wed Feb 12 13:17:16 2014 -0600

    Update oslo-incubator log.py to a01f79c

    This updates the log module from oslo-incubator to
    a01f79c3050962fd744239956e9654407d14ea1f

     $ git checkout a01f79c3050962fd744239956e9654407d14ea1f
     $ python update.py --nodeps --base keystone \
         --dest-dir ../keystone --modules log

    This includes a fix for the deprecated logger that caused the
    deprecated message to be printed multiple times rather than once.

    Change-Id: I6174b064205adcdc9fb966a9e01eb5190b5b730e
    Closes-Bug: #904307
    Closes-Bug: #1266812

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-3 → 2014.1
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.