unnecessary parameter is found in quota-classes request body

Bug #1266634 reported by Haiwei Xu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Haiwei Xu

Bug Description

Nova quota-classes request should be in the format like:

body = {'quota_class_set': {'instances': 50, 'cores': 50,
                            'ram': 51200, 'floating_ips': 10,
                            'fixed_ips': -1, 'metadata_items': 128,
                            'security_groups': 10,
                            'security_group_rules': 20,
                            'key_pairs': 100,
                            }}

But in some unit test cases, the id parameter is found in the body, it should be deleted.

 def test_quotas_update_as_admin(self):
     body = {'quota_class_set': {'instances': 50, 'cores': 50,
                                 'ram': 51200, 'floating_ips': 10,
                                 'fixed_ips': -1, 'metadata_items': 128,
                                 ★'id': 'test_class', ★
                                 'security_groups': 10,
                                 'security_group_rules': 20,
                                 'key_pairs': 100}}

Haiwei Xu (xu-haiwei)
Changed in nova:
assignee: nobody → Haiwei Xu (xu-haiwei)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/65212

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/65212
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c199a14039ddcde63896456ee25db68da1afcc8f
Submitter: Jenkins
Branch: master

commit c199a14039ddcde63896456ee25db68da1afcc8f
Author: Haiwei Xu <email address hidden>
Date: Tue Jan 7 23:43:58 2014 +0900

    Fix test case with wrong parameter in test_quota_classes

    The 'id' parameter is filled in the quota-classes request body in
    unit test, but it is not necessary. 'id' is passed to the server
    by the URL but not the body. This patch fixes this bug.

    Change-Id: I4014264e16031382277f6f1b520556a2a2690ad8
    Closes-Bug: #1266634

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.