internal neutron server error on tempest VolumesActionsTest

[Eugene Nikanorov]

The following traces were found when VolumesActionsTest has failed:

http://logs.openstack.org/18/63918/5/gate/gate-tempest-dsvm-neutron-pg-isolated/5a67370/console.html

http://logs.openstack.org/18/63918/5/gate/gate-tempest-dsvm-neutron-pg-isolated/5a67370/logs/screen-q-svc.txt.gz?level=TRACE#_2014-01-04_11_56_37_489

[Salvatore Orlando (salvatore-orlando)]

I've seen you've tagged this as ml2 - does it mean you've triaged it?

[Eugene Nikanorov (enikanorov)]

I've briefly looked at logs, the exception is thrown from ml2 plugin.

[Eugene Nikanorov (enikanorov)]

Apparently a race condition in ml2 plugin delete_port method.

[Eugene Nikanorov (enikanorov)]

Tempest logs indicate that there was just one attempt to delete a port from tempest via rest_client.
However neutron logs indicate that there was 2 incoming delete requests for the same port nearly at the same time.

I can't find the reason for that condition from the logs.

Anyway, the logic in ml2 delete_port is flawed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/65951

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/65951
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d9bcd597c67900472709cd11604afe1616e0af4e
Submitter: Jenkins
Branch: master

commit d9bcd597c67900472709cd11604afe1616e0af4e
Author: Eugene Nikanorov <email address hidden>
Date: Thu Jan 9 13:23:02 2014 +0400

    Fix race condition on ml2 delete and update port methods

    Synchronize access to ports table when deleting and updating
    a port. Otherwise concurrent update/delete request for the same port
    may cause neutron server to throw an exception and return
    '500 Internal server error' for such requests.

    Change-Id: I868002643147ce6baace5671cffb38b4f5e66729
    Closes-Bug: #1266537

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/66670