duplicate __init__() in ExtensionResource
Bug #1266344 reported by
Kun Huang
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Kun Huang |
Bug Description
Let's go in codes directly, to get resources from extension, the child class[0] has an __init__() to register itself, and the farther class [1]'s __init__() has already did this. If there are no some specified variables needed by child class, the child's __init__ could be removed. In <nova>/
[0] https:/
[1] https:/
Changed in nova: | |
assignee: | nobody → Kun Huang (academicgareth) |
Changed in nova: | |
milestone: | none → icehouse-3 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-3 → 2014.1 |
To post a comment you must log in.
For example, floating_ ip_dns. py[3] uses __init__ correctly because it needs another variable and doesn't do the duplicate thing.
https:/ /github. com/openstack/ nova/blob/ master/ nova/api/ openstack/ compute/ contrib/ floating_ ip_dns. py#L289