Storwize cinder volume driver have unused error message.

Bug #1266321 reported by Jia Ming Zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Jia Ming Zhang

Bug Description

In the cinder volume Storwize driver, the do_setup will check the iogrp is ready or not. If the io_grp data read have exception raised, there's a legacy 'vdisk_count' which is legacy and unnecessary for this ValueError.
The 'vdisk': iogrp_data['vdisk_count'] should be removed from the message.

Tags: driver
Revision history for this message
Jia Ming Zhang (jmzhang) wrote :

The code snippet is as following. The iogrp_data['vdisk_count'] should be a legacy variable to be checked but it is no-longer used now.

except ValueError:
                msg = (_('Expected integers for node_count and vdisk_count, '
                         'svcinfo lsiogrp returned: %(node)s and %(vdisk)s') %
                       {'node': iogrp_data['node_count'],
                        'vdisk': iogrp_data['vdisk_count']})

tags: added: driver
Changed in cinder:
assignee: nobody → Jia Ming Zhang (jmzhang)
assignee: Jia Ming Zhang (jmzhang) → nobody
Jia Ming Zhang (jmzhang)
Changed in cinder:
assignee: nobody → Jia Ming Zhang (jmzhang)
Jia Ming Zhang (jmzhang)
Changed in cinder:
status: New → Confirmed
status: Confirmed → In Progress
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/65039
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ae7fcdab7813dbb2e682b00b817e796a9c30a3f8
Submitter: Jenkins
Branch: master

commit ae7fcdab7813dbb2e682b00b817e796a9c30a3f8
Author: Lynxzh <email address hidden>
Date: Mon Jan 6 11:45:33 2014 +0800

    Remove unused message from iogrp_data setup

    The iogrp_data is initialized during do_setup loaded.
    The vdisk_count is originally used but later removed.
    In ValueException raised, the variable is no longer required.
    Remove this will give a clearer message when
    ValueException raised.

    Change-Id: Ib7b6c6a870ddd7932e8da1436d615f9ee458bd93
    Closes-Bug: #1266321

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.