raise exceptions.from_response is called with lesser number of arguments

Bug #1266239 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-troveclient
Fix Released
Low
Sushil Kumar

Bug Description

troveclient.openstack.common.apiclient.exceptions has the method from_response which has 3 arguments in its signature.

def from_response(response, method, url):

However, while calling troveclient is calling with only two arguments: raise exceptions.from_response(resp, body)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/65003

Changed in python-troveclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-troveclient (master)

Reviewed: https://review.openstack.org/65003
Committed: https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=a35d35824045f3e05d101cb759f59a691848085b
Submitter: Jenkins
Branch: master

commit a35d35824045f3e05d101cb759f59a691848085b
Author: Sushil Kumar <email address hidden>
Date: Sun Jan 5 17:45:35 2014 +0000

    Updates common.check_for_exceptions and its calls

    Reasons:
    - exceptions.from_response has 3 arguments but is being called with
      one argument less, which is url.

    Changes:
    - Updated common.check_for_exceptions to support urls as needed by
      troveclient.openstack.common.apiclient.exceptions.from_response.
    - Adds url to exceptions.from_response calls in troveclient.

    Closes-Bug: #1266239

    Change-Id: Ie18c90349479f740369f63c48a8d9b463641f84d

Changed in python-troveclient:
status: In Progress → Fix Committed
Changed in python-troveclient:
status: Fix Committed → Fix Released
importance: Undecided → Low
milestone: none → python-troveclient-v1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.