Use strutils.to_slug() instead of utils.slugify()

Bug #1266127 reported by Chris Buccella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Python client library for Sahara
Fix Released
Undecided
Sergey Lukjanov
python-cinderclient
Invalid
Low
Chris Buccella
python-manilaclient
Fix Released
Undecided
Valeriy Ponomaryov
python-troveclient
Fix Released
Low
Masaki Matsushita
python-cinderclient (Ubuntu)
Won't Fix
Undecided
Chris Buccella

Bug Description

Oslo provides a function, to_slug() in strutils that is substantially similar to slugify() provided in utils by python-cinderclient. Remove slugify() and use to_slug() instead.

Changed in python-cinderclient (Ubuntu):
assignee: nobody → ChrisBuccella (chris-buccella)
Eric Harney (eharney)
Changed in python-cinderclient:
assignee: nobody → ChrisBuccella (chris-buccella)
importance: Undecided → Low
Revision history for this message
Chuck Short (zulcss) wrote :

I am marking this "Wont Fix" in Ubuntu because when its fixed upstream then we will release a newer version.

Changed in python-cinderclient (Ubuntu):
status: New → Won't Fix
Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/95797

Changed in python-cinderclient:
assignee: Chris Buccella (chris-buccella) → Andre Naehring (naehring)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/95930

Changed in python-troveclient:
assignee: nobody → Christian Berendt (berendt)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-manilaclient (master)

Change abandoned by Christian Berendt (<email address hidden>) on branch: master
Review: https://review.openstack.org/96077

Changed in python-cinderclient:
assignee: Andre Naehring (naehring) → Chris Buccella (chris-buccella)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-saharaclient (master)

Reviewed: https://review.openstack.org/95927
Committed: https://git.openstack.org/cgit/openstack/python-saharaclient/commit/?id=e63cd72cd51958e84c3f298b6fb23f3c513d3f55
Submitter: Jenkins
Branch: master

commit e63cd72cd51958e84c3f298b6fb23f3c513d3f55
Author: Christian Berendt <email address hidden>
Date: Tue May 27 23:48:11 2014 +0200

    use strutils.to_slug() instead of utils.slugify()

    Change-Id: I4c07728ff795b4f4200256fc7629a29a7b1a4594
    Closes-Bug: #1266127

Changed in python-saharaclient:
status: New → Fix Committed
Changed in python-troveclient:
importance: Undecided → Low
milestone: none → python-troveclient-v1
Changed in python-manilaclient:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
Changed in python-troveclient:
assignee: Christian Berendt (berendt) → Nikhil Manchanda (slicknik)
Changed in python-troveclient:
assignee: Nikhil Manchanda (slicknik) → Christian Berendt (berendt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/100831
Committed: https://git.openstack.org/cgit/stackforge/python-manilaclient/commit/?id=07ee1bcb0c3c17032901b6813ab2a13439061495
Submitter: Jenkins
Branch: master

commit 07ee1bcb0c3c17032901b6813ab2a13439061495
Author: Valeriy Ponomaryov <email address hidden>
Date: Wed Jun 18 05:18:36 2014 -0400

    Code cleanup: use oslo's to_slug() instead of slugify()

    The bash completion code is the sole user of the slugify() function
    in utils, which is substantially similar to to_slug() provided in
    strutils from oslo. Remove slugify() and use to_slug() instead.

    Change-Id: Iffab2f59504ee7ec6528860e06a5140ff22f332f
    Closes-Bug: #1266127

Changed in python-manilaclient:
status: New → Fix Committed
Changed in python-manilaclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-troveclient (master)

Change abandoned by Christian Berendt (<email address hidden>) on branch: master
Review: https://review.openstack.org/95930

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-cinderclient (master)

Change abandoned by Chris Buccella (<email address hidden>) on branch: master
Review: https://review.openstack.org/64981
Reason: common/apiclient/base.py already does this now; this change is no longer needed

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/95797

Changed in python-saharaclient:
status: Fix Committed → Fix Released
milestone: none → 0.7.1
assignee: nobody → Sergey Lukjanov (slukjanov)
Changed in python-cinderclient:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/365430

Changed in python-troveclient:
assignee: Christian Berendt (berendt) → Masaki Matsushita (mmasaki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-troveclient (master)

Reviewed: https://review.openstack.org/365430
Committed: https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=b592b42aa1a8a9683af40fa1c011c7cd1665b45a
Submitter: Jenkins
Branch: master

commit b592b42aa1a8a9683af40fa1c011c7cd1665b45a
Author: Christian Berendt <email address hidden>
Date: Tue May 27 23:54:03 2014 +0200

    Use strutils.to_slug() instead of utils.slugify()

    Oslo provides a function, to_slug() in strutils that is substantially
    similar to slugify() provided in utils by python-troveclient. Remove
    slugify() and use to_slug() instead.

    Change-Id: I97bc7cfc2c0e7d14e7617037bff431cdc1eee50f
    Closes-Bug: #1266127
    Author: Christian Berendt <email address hidden>

Changed in python-troveclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-troveclient 2.6.0

This issue was fixed in the openstack/python-troveclient 2.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.