virtualbox scripts require ifconfig

[Andrew Woodward]

As to a conversation with a IRC user, we found that VBoxManage uses ifconfig to set the IP address on the vboxnet0 interface. A check needs to be added to ensure ifconfig is present.

[Ryan Moe (rmoe)]

We need to check specifically for /sbin/ifconfig. One of the vbox tools has a hard-coded path to /sbin/ifconfig

ryan@debian:~$ strings /usr/lib/virtualbox/VBoxNetAdpCtl | grep -i ifconfig
/sbin/ifconfig
ryan@debian:~$

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/74084

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/74084
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=1388ab3d1b2b280a85fd1f836e105b6dde9f5ed3
Submitter: Jenkins
Branch: master

commit 1388ab3d1b2b280a85fd1f836e105b6dde9f5ed3
Author: Miroslav Anashkin <email address hidden>
Date: Mon Feb 17 20:28:10 2014 +0400

    Virtualbox scripts require ifconfig

    Added check for /sbin/ifconfig existence under Linux/MacOS
    Added check for ipconfig under Windows/Cygwin

    Change-Id: I81ec63d5141ece93fd0119d63f1c2ee430a4b1c8
    Closes-Bug: #1265902

[Anastasia Palkina (apalkina)]

Verified.

anastasia@anastasia-X9SRE-X9SRE-3F-X9SRi-X9SRi-3F:~$ sudo mv /sbin/ifconfig /sbin/ifconfig1
anastasia@anastasia-X9SRE-X9SRE-3F-X9SRi-X9SRi-3F:~$ cd Product/fuel-main/virtualbox/
anastasia@anastasia-X9SRE-X9SRE-3F-X9SRi-X9SRi-3F:~/Product/fuel-main/virtualbox$ ./launch.sh
Checking for 'expect'... OK
If you run this script under Cygwin, you may have to add path to VirtualBox directory to your PATH.
Usually it is enough to run "export PATH=$PATH:"/cygdrive/c/Program Files/Oracle/VirtualBox"
Checking for "VBoxManage"... OK
Checking for VirtualBox Extension Pack... OK
Checking for Mirantis OpenStack ISO image... OK
Checking if SSH client installed...
OK
Checking if ipconfig or ifconfig installed...
No ifconfig available at /sbin/ifconfig path! This path is hard-coded into VBoxNetAdpCtl utility.Please install ifconfig or create symlink to proper interface configuration utility.anastasia@anastasia-X9SR