close modal when pressing escape on select

Bug #1265869 reported by Maxime Vidori
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Maxime Vidori

Bug Description

When we are in a modal, if a select is triggered and the user press escape all the modal is closed instead of closing the select.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64862

Changed in horizon:
assignee: nobody → Maxime Vidori (maxime-vidori)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/64862
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=37e4403ee87830e62a27e1b50f6681e4d012f70e
Submitter: Jenkins
Branch: master

commit 37e4403ee87830e62a27e1b50f6681e4d012f70e
Author: Maxime Vidori <email address hidden>
Date: Fri Jan 3 18:00:53 2014 +0100

    Do not close modal if escape is pressed on select

        The modal no longer fades out when pressing escape if a select is
    open. After this, the select input is unfocused, so the second press
    on escape will still close the modal.

    Fixes bug #1265869

    Change-Id: I49fa4431152fa3101bb6fafa6e07c8f908396ba8

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.