duplicate index on block_device_mapping ('instance_uuid', 'device_name')

[Dan Prince]

Due to an upgrade issue in Havana DB migration 186 there is now a duplicate index on the block_device_mapping ('instance_uuid', 'device_name') column for MySQL. (does not affect PostgreSQL).

DROP TABLE IF EXISTS `block_device_mapping`;
/*!40101 SET @saved_cs_client = @@character_set_client */;
/*!40101 SET character_set_client = utf8 */;
CREATE TABLE `block_device_mapping` (
  `created_at` datetime DEFAULT NULL,
  `updated_at` datetime DEFAULT NULL,
  `deleted_at` datetime DEFAULT NULL,
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `device_name` varchar(255) DEFAULT NULL,
  `delete_on_termination` tinyint(1) DEFAULT NULL,
  `snapshot_id` varchar(36) DEFAULT NULL,
  `volume_id` varchar(36) DEFAULT NULL,
  `volume_size` int(11) DEFAULT NULL,
  `no_device` tinyint(1) DEFAULT NULL,
  `connection_info` mediumtext,
  `instance_uuid` varchar(36) DEFAULT NULL,
  `deleted` int(11) DEFAULT NULL,
  `source_type` varchar(255) DEFAULT NULL,
  `destination_type` varchar(255) DEFAULT NULL,
  `guest_format` varchar(255) DEFAULT NULL,
  `device_type` varchar(255) DEFAULT NULL,
  `disk_bus` varchar(255) DEFAULT NULL,
  `boot_index` int(11) DEFAULT NULL,
  `image_id` varchar(36) DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `snapshot_id` (`snapshot_id`),
  KEY `volume_id` (`volume_id`),
  KEY `block_device_mapping_instance_uuid_idx` (`instance_uuid`),
  KEY `block_device_mapping_instance_uuid_device_name_idx` (`instance_uuid`,`device_name`),
  KEY `block_device_mapping_instance_uuid_virtual_name_device_name_idx` (`instance_uuid`,`device_name`),
  KEY `block_device_mapping_instance_uuid_volume_id_idx` (`instance_uuid`,`volume_id`),
  CONSTRAINT `block_device_mapping_instance_uuid_fkey` FOREIGN KEY (`instance_uuid`) REFERENCES `instances` (`uuid`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
/*!40101 SET character_set_client = @saved_cs_client */;

*** We should drop the block_device_mapping_instance_uuid_virtual_name_device_name_idx index for MySQL in IceHouse.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109104

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109104
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=138242a0b30480ae42f7160d5c3d98dddfe52d8d
Submitter: Jenkins
Branch: master

commit 138242a0b30480ae42f7160d5c3d98dddfe52d8d
Author: Johannes Erdfelt <email address hidden>
Date: Wed Jul 23 13:07:20 2014 -0700

    Remove duplicate index from block_device_mapping table

    Migration 186 (doesn't exist anymore) deleted the column virtual_name
    from the the block_device_mapping table. This ended up modifying an
    index (block_device_mapping_instance_uuid_virtual_name_device_name_idx)
    to be identical to (block_device_mapping_instance_uuid_device_name_idx)

    Closes-Bug: 1265839
    Change-Id: Ib293220eb764e9810212d121ce7889e6aefc266e