Cinder

_volume_upload_image function lost without doing verification for 'force' parameter

Bug #1265718 reported by ling-yun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
ling-yun
Cinder 2014.1 "icehouse"

Bug Description

_volume_upload_image API should only support to upload 'in-use' volume to image when assign 'force' parameter as true value. Now _volume_upload_image API does not do verification for 'force' parameter, so we can upload 'in-use' volume to image when assign 'force' parameter with string value 'false' or 'false111'. This patch add verification for 'force' parameter.

ling-yun (zengyunling)
Changed in cinder:
assignee: nobody → ling-yun (zengyunling)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64794

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/64794
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=04e333f78ec8f22cdc0f0ab8701ae6a277bacbd5
Submitter: Jenkins
Branch: master

commit 04e333f78ec8f22cdc0f0ab8701ae6a277bacbd5
Author: ling-yun <email address hidden>
Date: Fri Jan 3 15:56:05 2014 +0800

    add 'force' verification in _volume_upload_image

    _volume_upload_image API should only support to upload 'in-use' volume to
    image when assign 'force' parameter as true value. Now
    _volume_upload_image API does not do verification for 'force' parameter,
    so we can upload 'in-use' volume to image when assign 'force' parameter
    with string value 'false' or 'false111'. This patch add verification for
    'force' parameter.

    Change-Id: I9e1d0e517d0ff97c136903dd6e50a305e18651f3
    Closes-Bug: #1265718

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/65037

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.