image is creating with option min_disk and min_ram as negative number

[renminmin]

I try to create a image with the min_ram and min_disk as negative number, and create image operation is successful.
I use the glance api V2 to create image.

curl -i -X POST -H "X-Auth-Token: $token" -H "content-type: application/json" -d '{"name": "image-7", "type": "kernel", "foo": "bar", "disk_format": "aki", "container_format": "aki", "protected": false, "tags": ["test","image"], "visibility": "public", "min_ram":-1, "min_disk":-1' \
http://192.168.0.100:9292/v2/images

glance image-show image-7

+------------------+--------------------------------------+
| Property | Value |
+------------------+--------------------------------------+
| Property 'foo' | bar |
| Property 'type' | kernel |
| container_format | aki |
| created_at | 2014-01-03T06:01:14 |
| deleted | False |
| disk_format | aki |
| id | aaa8e463-10aa-4518-a590-52feebaabcb5 |
| is_public | True |
| min_disk | -1 |
| min_ram | -1 |
| name | image-7 |
| owner | 25adaa8f93ee4199b6a362c45745231d |
| protected | False |
| status | queued |
| updated_at | 2014-01-03T06:01:14 |
+------------------+--------------------------------------+

I think glance need to check the value of min_ram and min_disk. They need to be greater than or equal 0.

[Feilong Wang (flwang)]

Can you help verify if v1 has the same issue? Thanks.

[Yanis Guenane (yanis-guenane)]

I confirm that v1 has the same issue

stack@devstack:~/devstack$ glance image-create --name alex --min-disk -1 --min-ram -1
+------------------+--------------------------------------+
| Property | Value |
+------------------+--------------------------------------+
| checksum | None |
| container_format | None |
| created_at | 2014-01-06T21:20:30 |
| deleted | False |
| deleted_at | None |
| disk_format | None |
| id | e3637dce-45b4-4076-ad72-953e579618fe |
| is_public | False |
| min_disk | -1 |
| min_ram | -1 |
| name | alex |
| owner | e22f499513e744e9829f461ede787788 |
| protected | False |
| size | 0 |
| status | queued |
| updated_at | 2014-01-06T21:20:30 |
+------------------+--------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/65354

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/65354
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=a5b78ae0b502ad0ee95037f5b1d9619dba3dab81
Submitter: Jenkins
Branch: master

commit a5b78ae0b502ad0ee95037f5b1d9619dba3dab81
Author: Yanis Guenane <email address hidden>
Date: Tue Jan 7 19:45:26 2014 +0000

    Prevent min_disk and min_ram from being negative

    At the moment, in both api versions, min_disk and min_ram can be set to
    negative value - which doesn't make sense. This commit fixes this behavior
    in the two versions of the glance api.

    Change-Id: Ib7855c1d928ab8262dd2a109619a4e3d2299ff9e
    Closes-bug: #1265711

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/85880