Fix use the fact that empty sequences are false

Bug #1265688 reported by Liusheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Liusheng

Bug Description

For sequences(strings, lists, tuples), in order to consistent with pep8 recommendations, 'if len(seq)' should be replaced with 'if seq', and 'if not len(seq)' should be replaced with 'if not seq'.

Liusheng (liusheng)
Changed in ceilometer:
assignee: nobody → Liusheng (liusheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64768

Changed in ceilometer:
status: New → In Progress
gordon chung (chungg)
Changed in ceilometer:
importance: Undecided → Critical
importance: Critical → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/64768
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=00f44590859610c9f0ceea70e30f82c288f3e468
Submitter: Jenkins
Branch: master

commit 00f44590859610c9f0ceea70e30f82c288f3e468
Author: ls1175 <email address hidden>
Date: Fri Jan 3 11:03:27 2014 +0800

    Fix use the fact that empty sequences are false

    For sequences(strings, lists, tuples), in order to consistent with
    pep8 recommendations, 'if len(seq)' should be replaced with 'if seq',
    and 'if not len(seq)' should be replaced with 'if not seq'.

    Change-Id: Ie7b6afbde07bb57a05b36d92a079c5355945b262
    Closes-Bug: #1265688

Changed in ceilometer:
status: In Progress → Fix Committed
gordon chung (chungg)
Changed in ceilometer:
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.