Log message is not clear when scale out/in

Bug #1265315 reported by Guangya Liu (Jay Lau)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Guangya Liu (Jay Lau)

Bug Description

When I create two stacks with same template with autoscaling group, then when scale out/in, the log message would be as:

"HadoopSGroup" : {
      "Type" : "AWS::AutoScaling::AutoScalingGroup",
      "Properties" : {
        "AvailabilityZones" : ["nova"],
        "LaunchConfigurationName" : { "Ref" : "LaunchConfig" },
        "MinSize" : "1",
        "MaxSize" : "1"
      }
    },

    "HadoopSlaveScaleUpPolicy" : {
      "Type" : "AWS::AutoScaling::ScalingPolicy",
      "Properties" : {
        "AdjustmentType" : "ChangeInCapacity",
        "AutoScalingGroupName" : { "Ref" : "HadoopSGroup" },
        "Cooldown" : "30",
        "ScalingAdjustment" : "1"
      }
    },

2014-01-01 09:44:07.541 INFO heat.engine.resources.autoscaling [-] HadoopSlaveScaleUpPolicy Alarm, adjusting Group HadoopSGroup by 1

Though I created two stacks, but the log message for scale up is same for those two stacks, it is better that we add scaling group id in log message

Changed in heat:
assignee: nobody → Jay Lau (jay-lau-513)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64606

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/64606
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b4771910ab3f0620fc7ba5c4750b313d5ef6132b
Submitter: Jenkins
Branch: master

commit b4771910ab3f0620fc7ba5c4750b313d5ef6132b
Author: Jay Lau <email address hidden>
Date: Wed Jan 1 09:17:55 2014 -0500

    Update log message for scale out/in

    When create two stacks with same template with autoscaling group,
    then when scale out/in, the log message would be as
    (HadoopSlaveScaleUpPolicy is my scale up alarm and HadoopSGroup is
    my autoscaling group):

    HadoopSlaveScaleUpPolicy Alarm, adjusting Group HadoopSGroup by 1

    From above log message, I do not know which stack is being scaled up.

    This patch add scale group id to the log message so that we can know
    which group is being scale out/in.

    Change-Id: Ie4862e9738c652b813b3dae01f9aeb3557e79b9a
    Closes-Bug: #1265315

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.