Wrong usage of log.exception in dashboard code

Bug #1264980 reported by Timur Sufiev
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Ekaterina Chernova

Bug Description

There are a lot of places in murano-dashboard where calls like 'log.exception(e)' are used. They should be rewritten, because http://docs.python.org/2/library/logging.html#logging.Logger.exception

Tags: verified
Timur Sufiev (tsufiev-x)
Changed in murano:
importance: Undecided → Medium
milestone: none → 0.4.1
assignee: nobody → Ekaterina Fedorova (efedorova)
Changed in murano:
status: New → Confirmed
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/65667
Committed: https://git.openstack.org/cgit/stackforge/murano-dashboard/commit/?id=6261c35b533cfadc344ab1e98a536b343f460c46
Submitter: Jenkins
Branch: master

commit 6261c35b533cfadc344ab1e98a536b343f460c46
Author: Ekaterina Fedorova <email address hidden>
Date: Thu Jan 9 14:53:40 2014 +0400

    Extend exception messages.

    Closes-bug: #1264980
    Change-Id: Ia57821cd906a203b18546b9e93e38f3e1bc71025

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-repository (master)

Reviewed: https://review.openstack.org/65937
Committed: https://git.openstack.org/cgit/stackforge/murano-repository/commit/?id=e83b48becf03f76fed08593ed9721d25fb3cb52c
Submitter: Jenkins
Branch: master

commit e83b48becf03f76fed08593ed9721d25fb3cb52c
Author: Ekaterina Fedorova <email address hidden>
Date: Fri Jan 10 16:54:30 2014 +0400

    Fix log.exception usage. Add log translating

    Partially fixes bug: #1267514

    Change-Id: I4b017f78b880e67b5dbe4369e347ee7180462bec
    Closes-bug: #1264980

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-repository (release-0.4)

Fix proposed to branch: release-0.4
Review: https://review.openstack.org/67429

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-repository (release-0.4)

Reviewed: https://review.openstack.org/67429
Committed: https://git.openstack.org/cgit/stackforge/murano-repository/commit/?id=72337dc3ac680402713ec95d48c5a6aa35b59bad
Submitter: Jenkins
Branch: release-0.4

commit 72337dc3ac680402713ec95d48c5a6aa35b59bad
Author: Ekaterina Fedorova <email address hidden>
Date: Fri Jan 10 16:54:30 2014 +0400

    Update from master with following commits

    * Fix log.exception usage. Add log translating
      Closes-bug: #1264980

    * Add per-tenant isolation
      Implements blueprint per-tenant-isolation

    * Fixed issue with Key Pairs for Linux-based services
      Implements: blueprint rewrite-key-pair-for-linux-based-services
    * Add service_definition directory existence checkup
      Closes-Bug: #1269431

    * Make some refactoring

    * Add forgotten return
      Closes-Bug: #1249303

    * Add forgotten return statements
      Closes-Bug: #1268934

    * Fix error code when there is no input json

    * Return correct http code
      Closes-Bug: #1268976

    Change-Id: I726d8b8849b2ccd44fdbf9d7b4ce65f3a62cf4aa

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (release-0.4)

Fix proposed to branch: release-0.4
Review: https://review.openstack.org/68339

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (release-0.4)

Reviewed: https://review.openstack.org/68339
Committed: https://git.openstack.org/cgit/stackforge/murano-dashboard/commit/?id=b93fb120b7f5ab2c190cb021f127c39631f0f5b3
Submitter: Jenkins
Branch: release-0.4

commit b93fb120b7f5ab2c190cb021f127c39631f0f5b3
Author: Ekaterina Fedorova <email address hidden>
Date: Thu Jan 9 14:53:40 2014 +0400

    Cherry-pick the following commits from master:

    * Extend exception messages.
      Closes-bug: #1264980
      Ia57821cd906a203b18546b9e93e38f3e1bc71025
    * Remove extra methods of interaction with API:
      and use environment_get instead it.
      Closes-Bug: #1265165
      Ib49aecff4773773b6cf305d51db29a17bcf813f3
    * Move most of code for dynamic UI form creation into metaclass.
      Implements: blueprint dynamic-ui-optimization
      I9b2617527b410abb7c60df978f9c00f7cef491d3
    * Minor refactoring of dynamic_ui.
      Move more functions to dynamic_ui.helpers.
      Ib578a24159dda4de5fecf5df35ff71bc7d704215
    * Rewrite dynamic_ui to store Services data per-session.
      Thus set of Services (and cleaned_data for them) for each
      user/tenant will be isolated supporting per-tenant isolation
      blueprint.
      Closes-bug: #1264289
      I3d0b46463470912cf6d7a36fddd84292689775da
    * Update local_settings.py.example to stable/havana.
      If56e74338449eb14b6b8a581863502287e654517
    * Hide "Upload UI file" btn in manage service table
      There is should be only one ui definition in service So need to show
      "Upload UI file" only ic case there is no any
      Closes-bug: #1263052
      Ibe8c74f20062cd213d8a53ff46d9db9d41a2e08d
    * Support per-tenant isolation for service metadata files.
      Partially implements: blueprint per-tenant-isolation
      I7393e748216ddaa59d6e90249b263514d08f9d34
    * Added empty line in KeyPair fields.
      Implements: blueprint rewrite-key-pair-for-linux-based-services
      If7dcf19084422c76d3bd1b075e4d5080254d003b

    Change-Id: I10b920a3b7cdd9b9a19d37243be81f6aa6aafa9b

tags: added: verified
Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.