exception.BadRequest is raised with incorrectly logged message.

Bug #1264688 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Sushil Kumar

Bug Description

exception.BadRequest is called with incorrect log messages in two instances.

1. trove/guestagent/datastore/mysql/service.py defines a method MySqlAdmin._get_user is raising exception.BadRequest with incorrect message, for which the correct message does not gets displayed when exception is raised, the exception message displayed is the default message of BadRequest.

2. Another such instance is in trove/instance/models.py Instance.resize_volume._resize_resources.
There is a need to correct that log message, so that it correct messages comes to user-screen.

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64338

Changed in trove:
status: New → In Progress
summary: - exception.BadRequest has a hardcoded message
+ exception.BadRequest is being called with incorrectly logged message.
summary: - exception.BadRequest is being called with incorrectly logged message.
+ exception.BadRequest is called with incorrectly logged message.
description: updated
summary: - exception.BadRequest is called with incorrectly logged message.
+ exception.BadRequest is raised with incorrectly logged message.
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/64338
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=3b6aebe0c5d602fab7913bdde450d87ea3ceab76
Submitter: Jenkins
Branch: master

commit 3b6aebe0c5d602fab7913bdde450d87ea3ceab76
Author: Sushil Kumar <email address hidden>
Date: Sat Dec 28 16:22:22 2013 +0000

    Adds Missing _() for Exception Message Translation

    Reasons:
    - Exception messages missing underscores. This is necessary to
      mark messages as ready for translation, and is already the
      defacto standard across the trove codebase,as per,
      https://wiki.openstack.org/wiki/Translations
    - Because of incorrect Exception messages, it does not overrides
      the default message of BadRequest.

    Changes:
    - Adds the missing underscore function to wrap a few user-facing
      exception messages.

    Change-Id: Ib4a183f717146493e514b8169679a57cc2ecfd01
    Closes-Bug: #1264688

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.