Remove unused imports in glance

Bug #1264245 reported by Lee Li
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Lee Li

Bug Description

There are some unused import in glance. The command 'find . -type f -name "*py" -exec pylint -r n {} \; | grep -E "Unused imp|^\*"' check out one:
************* Module glance.tests.unit.test_image_cache
W: 33,0: Unused import glance

And there are some can't check out by this command, such as 'import domain' in v2.image_data.py.

Lee Li (lilinguo)
Changed in glance:
assignee: nobody → Lee Li (lilinguo)
Revision history for this message
Viktor Serhieiev (vsergeyev) wrote :

We already allowed F401 check in tox.ini. So its should be enough for us.

As for this module - I guess, that the issue is deeper. See the code of glance.tests.unit.test_image_cache module.

      32 #NOTE(bcwaldon): This is imported to load the registry config options
EE 33 import glance.registry # noqa

Revision history for this message
Lee Li (lilinguo) wrote :

How aboud 'import domain' in v2.image_data.py and 'import glance.store' in import glance.store and so on.

F401 check in tox.ini can check out there? Thanks.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64127

Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/64127
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=e896c69f6e57802f525da7fb6f5201daf23cd810
Submitter: Jenkins
Branch: master

commit e896c69f6e57802f525da7fb6f5201daf23cd810
Author: llg8212 <email address hidden>
Date: Thu Dec 26 19:07:27 2013 +0800

    Remove unused imports in glance

    There are some unused import in glance, such as 'import domain' in v2.image_data.py.

    Change-Id: I9c3f06bfde4dbf130dd8525fc00b3f73c30ab4d7
    Closes-Bug:#1264245

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.