xrange not support python3

Bug #1264182 reported by Liang Bo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Liang Bo

Bug Description

In file: openstack_dashboard/dashboards/project/access_and_security/security_groups/forms.py:
    if icmp_type not in xrange(-1, 256):
    if icmp_code not in xrange(-1, 256):

1. xrange is not supported in python3
2. we could replace xrange here with range

Liang Bo (liang-bo-os)
Changed in horizon:
assignee: nobody → Liang Bo (liang-bo-os)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64071

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/64071
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7ee87f3f518f4c3082b40c4d7c4b64201c122f00
Submitter: Jenkins
Branch: master

commit 7ee87f3f518f4c3082b40c4d7c4b64201c122f00
Author: Liang Bo <liang.bo.os@99cloud.net>
Date: Wed Dec 25 16:05:01 2013 -0800

    Replace xrange in for loop with range

    xrange is not supported in python 3, so replace it with range.
    It's not a large range size, so no need to use six.moves.range.

    Change-Id: Ie62c3f1651d98f6b7d9a70fa1b485a9a04fd758f
    Closes-Bug: #1264182

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Low
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.