Glance

Redundant code to set sql_connection

Bug #1264056 reported by Lee Li
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Lee Li
Glance 2014.1 "icehouse"

Bug Description

In methods 'version_control' and 'db_sync' in glance/db/sqlalchemy/migration.py, there are redundant code 'sql_connection = CONF.sql_connection'.

It will never be used because the ' _version_control' has the sentence.

Lee Li (lilinguo)
Changed in openstack-manuals:
assignee: nobody → Lee Li (lilinguo)
affects: openstack-manuals → glance
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64076

Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/64076
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=90c96e537fe0c9eef202619f22ca3ef4b44761a5
Submitter: Jenkins
Branch: master

commit 90c96e537fe0c9eef202619f22ca3ef4b44761a5
Author: llg8212 <email address hidden>
Date: Thu Dec 26 09:09:06 2013 +0800

    Remove the redundant code

    In methods 'version_control' and 'db_sync' in glance/db/sqlalchemy/migration.py,
    there are redundant code 'sql_connection = CONF.sql_connection'.
    The 'sql_connection's are local variable and not used.

    Change-Id: Ie8a12e6f385f7103463172ed9acde1de0336a6d4
    Closes-Bug:#1264056

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.