Unlock settings in case of before deployment validation error and new cluster

[Andrey Korolyov]

ISO #200.

Steps to reproduce:
- create new HA cluster, check all Ceph boxes, set RF=3
- add three controllers and two compute+osds
- hit Deploy button

Expected: red warning
Got: nothing

[Andrey Korolyov (xdeller)]

Any progress here?

[Andrey Korolyov (xdeller)]

Update - warning actually presented but after start of actual Deployment therefore Settings tab is locked and I cannot reduce RF. Please fix ASAP.

[Evgeniy L (rustyrobot)]

So, we discussed this problem, the problem is that user can't change replication factor if he made a mistake.
Because cluster was moved to error state (because validation failed).

We can keep settings unlock in case if before deployment task failed

[Evgeniy L (rustyrobot)]

I moved it to 4.1 as a result of discussion with Nastya U, and Andrey K.

[Evgeniy L (rustyrobot)]

We discussed this issue with Julia.
In nailgun we shouldn't change state of cluster in case of failed validation, because validation didn't start yet, also we need to add persistent task in db check_before_delpoyment and move this task to error status and to add a message with error, UI will be able to request this task and show the banner with error message.

[Mike Scherbakov (mihgen)]

What's the status of this now?

[Evgeniy L (rustyrobot)]

Mike, afaik nobody started to work on this task.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/72398

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72398
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=b294280f74d9cf39b5adfebf1e92824e3730c12b
Submitter: Jenkins
Branch: master

commit b294280f74d9cf39b5adfebf1e92824e3730c12b
Author: Evgeniy L <email address hidden>
Date: Mon Feb 10 20:01:00 2014 +0400

    Don't lock settings if cluster is new
    and before deployment validation failed

    * not set cluster status to error
      if before deployment validation
      tasks failed and cluster is new
    * move assignment of 'deployment'
      status after all data searilization
      and before deployment validation

    Closes-bug: #1263935
    Change-Id: I1e4690380959897b91c4abe847e4c8672343884e

[Anastasia Palkina (apalkina)]

Verified on ISO #112
"build_id": "2014-02-12_01-17-30",
"ostf_sha": "d15d6b5b952e455e3afff383413ffa6d89ee7981",
"build_number": "112",
"nailgun_sha": "cd4cfb9ce02496121e7e17b41d7334c60028c50e",
"fuelmain_sha": "768f09acf2e775b3c7c30fd3ee17eda723927fac",
"astute_sha": "d002c3bf626cff96a1d4aec9eb92fc4d5f4542c4",
"release": "4.1",
"fuellib_sha": "518146d5c0a69918e2850f6ad7dab0b1e4e94c03"