Host name validation does not check length of hostname

Bug #1263662 reported by Timur Nurlygayanov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Timur Sufiev

Bug Description

Host Name parameter for Murano services it is the NET BIOS names for Windows-Based services. And we should validate that this parameter has length < 16 characters, because this is criteria from Microsoft (proof link: http://support.microsoft.com/kb/163409/en)

Tags: verified
Changed in murano:
milestone: none → 0.4.1
assignee: nobody → Timur Sufiev (tsufiev-x)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-repository (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64024

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-repository (master)

Reviewed: https://review.openstack.org/64024
Committed: https://git.openstack.org/cgit/stackforge/murano-repository/commit/?id=5557228d01a90b8469f981937d265d919f2ab725
Submitter: Jenkins
Branch: master

commit 5557228d01a90b8469f981937d265d919f2ab725
Author: Timur Sufiev <email address hidden>
Date: Wed Dec 25 16:49:36 2013 +0400

    Restrict hostname template length for Windows services by 15 symbols.

    This restriction still does not consider '#' transferring into 2-digit
    number, because it's not very likely to have more than 10 instances of
    one service.

    Change-Id: I5d76bbbfc1bf6b0a549218c817fcf0219b5ac386
    Fixes-bug: #1263662

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-repository (release-0.4)

Fix proposed to branch: release-0.4
Review: https://review.openstack.org/66295

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-repository (release-0.4)

Reviewed: https://review.openstack.org/66295
Committed: https://git.openstack.org/cgit/stackforge/murano-repository/commit/?id=a282a578ff732054297bca78e99b5b3387546723
Submitter: Jenkins
Branch: release-0.4

commit a282a578ff732054297bca78e99b5b3387546723
Author: Ekaterina Fedorova <email address hidden>
Date: Thu Dec 12 20:34:07 2013 +0400

    Cherry-pick the following commits from master:

    * Handle situation when there is no manifest in uploading archive
      I66b1e55561f8a1bfeb7a6475ef36916c22f28cb4
    * Lead all manifests to the one style
      Fix service_version to increment it easier
      Fixes bug: #1262242
      I42d10f43f7febaf57aa942aa9713df350197acb1
    * Restrict hostname template length for Windows services by 15 symbols.
      This restriction still does not consider '#' transferring into 2-digit
      number, because it's not very likely to have more than 10 instances of
      one service.
      I5d76bbbfc1bf6b0a549218c817fcf0219b5ac386
      Fixes-bug: #1263662
    * Return agent/Demo.template to the Services.
      I1edeb9c6060f42d7cf4df4a07b922da6fcfaa589
      Closes-bug: #1263047
    * Remove spam in logs from iso8601
      I0c1ef8ba25312a8081f28f0dbb7a9c2203f2f7c7

    Change-Id: I5d1b3105eef223f7b8eeed34b8999ba38bb2a4c1

tags: added: verified
removed: validation
Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.