Remove update_service_capabilities from nova

Bug #1263569 reported by Guangya Liu (Jay Lau)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Guangya Liu (Jay Lau)

Bug Description

From the comments of update_service_capabilities, it is said that once publish_service_capabilities was removed, then we can begin the process of its removal.

Now publish_service_capabilities has been removed, so we can remove update_service_capabilities now as no one is calling it

def update_service_capabilities(self, context, service_name,
                                    host, capabilities):
        """Process a capability update from a service node."""
        #NOTE(jogo) This is deprecated, but is used by the deprecated
        # publish_service_capabilities call. So this can begin its removal
        # process once publish_service_capabilities is removed.
        if not isinstance(capabilities, list):
            capabilities = [capabilities]
        for capability in capabilities:
            if capability is None:
                capability = {}
            self.driver.update_service_capabilities(service_name, host,
                                                    capability)

Changed in nova:
assignee: nobody → Jay Lau (jay-lau-513)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63659

Changed in nova:
status: New → In Progress
Changed in nova:
importance: Undecided → Low
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/63659
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4b4f0d61836e527340511f6198c2f2c0bdf70888
Submitter: Jenkins
Branch: master

commit 4b4f0d61836e527340511f6198c2f2c0bdf70888
Author: Jay Lau <email address hidden>
Date: Sun Dec 22 21:01:55 2013 -0500

    Remove update_service_capabilities from nova

    From the comments of update_service_capabilities, it is said that
    once publish_service_capabilities was removed, then we can begin the
    process of its removal.

    publish_service_capabilities has been removed in patch
    I31c21055163e94b712d337568b16b9b7a224b52f, so we can remove
    update_service_capabilities now.

    Change-Id: I46be33462321f5e3ff0904bdff8dbfe2fbe115cd
    Closes-Bug: #1263569

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
Jay Pipes (jaypipes) wrote :

See here for how this broke the compute capabilities filter:

https://bugs.launchpad.net/nova/+bug/1245541

Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.