Glance is not E125 Compliant

Bug #1263437 reported by Yanis Guenane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Yanis Guenane

Bug Description

Make Glance pep8 E125 compliant

Changed in glance:
assignee: nobody → Yanis Guenane (yanis-guenane)
Revision history for this message
Zhi Yan Liu (lzy-dev) wrote :

Should we also enable E126 ? It seems also make sense to me.

- E125: continuation line does not distinguish itself from next logical line
- E126: continuation line over-indented for hanging indent

Changed in glance:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Yanis Guenane (yanis-guenane) wrote :

You are right about making it in a single commit. Commit message will reflect that.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63620

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/63620
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=ec08ca1a872477c1907362dcfd665808ebf75db1
Submitter: Jenkins
Branch: master

commit ec08ca1a872477c1907362dcfd665808ebf75db1
Author: Yanis Guenane <email address hidden>
Date: Sun Dec 22 06:56:48 2013 +0000

    Make code base E125 and E126 compliant

    This commit makes the glance code base E125 and E126 compliant :
      * E125 continuation line does not distinguish itself from next logical line
      * E126 continuation line over-indented for hanging indent

    Change-Id: I7120149bedb665fb66320498fe98948602a6cd52
    Closes-bug: #1263437

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.