cobbler hardcoding options

[Chris Ricker]

With a havana cobbler I'm seeing a lot of preset default options we don't want

interfaces hard-named to eth2 / eth3 (in my box they should be eth0 / eth1)
puppetlabs apt repo set up which we don't want
timeserver set to build-server.cisco.com
puppet server set to build-server.cisco.com
proxy set to undefined variable
disable puppet agent option from g.3 not available
disk config options from g.3 not available

It looks like this mostly flows from cisco-preseed.template being included as an unparameterized file rather than populated via puppet with appropriate values

[Mark T. Voelker (mvoelker)]

Several commits related to this:

https://github.com/CiscoSystems/puppet_openstack_builder/pull/29
https://github.com/CiscoSystems/puppet_openstack_builder/pull/28
https://github.com/CiscoSystems/puppet-cobbler/pull/58
https://github.com/CiscoSystems/puppet-coi/pull/30

And possibly a few more coming.

[Mark T. Voelker (mvoelker)]

Restores disk config options:
https://github.com/CiscoSystems/puppet-coi/pull/32

[Mark T. Voelker (mvoelker)]

Missing timezone option:
https://github.com/CiscoSystems/puppet-coi/pull/33
And corresponding default in user.common.yaml:
https://review.openstack.org/#/c/65866

[Mark T. Voelker (mvoelker)]

Restores kernel cmdopts and ability to boot a specific kernel version:
https://github.com/CiscoSystems/puppet-coi/pull/34

[Mark T. Voelker (mvoelker)]

As far as I can tell the commits above take care of all the remaining issues. If we see spot anything we can open those as individual bugs.