openstack tests/site.pp fails to apply - Name must be a String not Array

[Ashley Cambrell]

On a vanilla Ubuntu 12.04.3,

Using an unchanged /etc/puppet/modules/openstack/tests/site.pp (except I added mysql_root_password (see #1263292)),

The apply fails with:

sudo puppet apply /etc/puppet/modules/openstack/tests/site.pp --certname openstack_all
Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera defaults
Warning: Scope(Class[Keystone]): token_format parameter is deprecated. Use token_provider instead.
Warning: Variable access via 'module_name' is deprecated. Use '@module_name' instead. template[/etc/puppet/modules/rabbitmq/templates/rabbitmq.config]:2
   (at /etc/puppet/modules/rabbitmq/templates/rabbitmq.config:2:in `result')
Warning: Variable access via 'config_cluster' is deprecated. Use '@config_cluster' instead. template[/etc/puppet/modules/rabbitmq/templates/rabbitmq.config]:4
   (at /etc/puppet/modules/rabbitmq/templates/rabbitmq.config:4:in `result')
Warning: Variable access via 'config_stomp' is deprecated. Use '@config_stomp' instead. template[/etc/puppet/modules/rabbitmq/templates/rabbitmq.config]:7
   (at /etc/puppet/modules/rabbitmq/templates/rabbitmq.config:7:in `result')
Warning: Variable access via 'port' is deprecated. Use '@port' instead. template[/etc/puppet/modules/rabbitmq/templates/rabbitmq-env.conf.erb]:1
   (at /etc/puppet/modules/rabbitmq/templates/rabbitmq-env.conf.erb:1:in `result')
Warning: Variable access via 'node_ip_address' is deprecated. Use '@node_ip_address' instead. template[/etc/puppet/modules/rabbitmq/templates/rabbitmq-env.conf.erb]:2
   (at /etc/puppet/modules/rabbitmq/templates/rabbitmq-env.conf.erb:2:in `result')
Warning: Scope(Class[Nova]): sql_connection deprecated for database_connection
Warning: Scope(Class[Nova]): sql_idle_timeout deprecated for database_idle_timeout
Warning: Scope(Class[Openstack::Horizon]): The cache_server_ip parameter is deprecated. Use memcached_listen_ip instead.
Notice: Compiled catalog for openstack_all in environment production in 7.33 seconds
Error: Parameter name failed on Package[nova-vncproxy]: Name must be a String not Array at /etc/puppet/modules/nova/manifests/generic_service.pp:44
Wrapped exception:
Name must be a String not Array

[Ashley Cambrell (acambrell)]

Relates to a change in puppet 3.4.0

https://groups.google.com/forum/#!topic/puppet-users/gxwDg8XUVqw

https://projects.puppetlabs.com/issues/22557

I've tracked it to:

/etc/puppet/modules/nova/manifests/params.pp:92: $vncproxy_package_name = ['novnc', 'nova-novncproxy']

I changed it to simply:

$vncproxy_package_name = 'nova-novncproxy'

and the apply finished.

I'm not sure of the impact of leaving out novnc of vncproxy_package_name.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/63606

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/63606
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=d4a8c904b775114a10edf5b1a696d6fcbf50e924
Submitter: Jenkins
Branch: master

commit d4a8c904b775114a10edf5b1a696d6fcbf50e924
Author: Mathieu Gagné <email address hidden>
Date: Sun Dec 22 01:03:11 2013 -0500

    Remove novnc from vncproxy packages list for Ubuntu

    Package resources can no longer have array for name since Puppet 3.4.

    Since the package nova-novncproxy already requires novnc,
    we can safely remove it from the list of packages to install.

    Closes-bug: #1263293
    Change-Id: Iba7ff0b7aedd750a54d931e0e8cbe37418ed6aed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/67746

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/67746
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=9e53295111a61126b80bb7f8affc8a07e0478327
Submitter: Jenkins
Branch: stable/havana

commit 9e53295111a61126b80bb7f8affc8a07e0478327
Author: Mathieu Gagné <email address hidden>
Date: Sun Dec 22 01:03:11 2013 -0500

    Remove novnc from vncproxy packages list for Ubuntu

    Package resources can no longer have array for name since Puppet 3.4.

    Since the package nova-novncproxy already requires novnc,
    we can safely remove it from the list of packages to install.

    Closes-bug: #1263293
    Change-Id: Iba7ff0b7aedd750a54d931e0e8cbe37418ed6aed
    (cherry picked from commit d4a8c904b775114a10edf5b1a696d6fcbf50e924)